Skip to content

Swap microformat-node for newer microformats-parser #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

Zegnat
Copy link
Member

@Zegnat Zegnat commented Dec 16, 2022

Closes #4.

This switches microformat-node to the newer microformats-parser.

The biggest change is to the yarn.lock file, as the newer parser has way less dependencies. I added one new dependency to be able to more accurately display the parser version we are loading. Otherwise I have kept the changes as little as possible. This means that submitting an HTML snippet is still broken and needs my other PR to get merged.

@Zegnat Zegnat changed the title Feature/switch parser Dec 16, 2022
Copy link
Member

@jalcine jalcine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Nice add with the version hint too!

@jalcine jalcine merged commit 746cfc6 into microformats:next Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants