Fix app and spec errors #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgarber623
commented
Apr 20, 2020
| @@ -17,7 +17,7 @@ def show | |||
|
|
|||
| render json: JSON.pretty_generate(results) | |||
| else | |||
| redirect_to new_submissions_path | |||
| redirect_to new_submission_path | |||
There was a problem hiding this comment.
Correcting route name.
| get :show | ||
| expect(response).to have_http_status(:success) | ||
| expect(response).to have_http_status(:redirect) |
There was a problem hiding this comment.
The controller action throws a redirect, so now the spec checks for that.
| @@ -4,7 +4,7 @@ | |||
| describe 'GET /submissions' do | |||
| it 'works! (now write some real specs)' do | |||
| get submissions_path | |||
| expect(response).to have_http_status(:ok) | |||
| expect(response).to have_http_status(:redirect) | |||
There was a problem hiding this comment.
Same as above: controller action throws a redirect.
| @@ -3,7 +3,6 @@ | |||
| RSpec.describe 'submissions/new', type: :view do | |||
| before do | |||
| assign(:submission, Submission.new( | |||
| url: 'MyText', | |||
There was a problem hiding this comment.
The Submission model doesn't have a url field on it, so this was throwing an error.
| assert_select 'textarea[name=?]', 'submission[html]' | ||
|
|
||
| assert_select 'textarea[name=?]', 'submission[base_url]' | ||
| assert_select 'input[name=?]', 'submission[base_url]' |
There was a problem hiding this comment.
Fixing spec to match page's markup.
| assert_select 'input[name=?][value=?]', 'submission[base_url]', 'MyText' | ||
|
|
||
| assert_select 'textarea[name=?]', 'submission[json]' | ||
| end |
There was a problem hiding this comment.
This set of assertions is an improvement over the string matching (which was breaking). This is a quick fix, but I'm sure it could be improved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While getting the app checked out and up-and-running, I found a handful of spec errors that would reasonably prevent moving forward with dependency updates.
So… this PR addresses those errors. I'll post comments alongside the changes for context. Feedback appreciated. Thanks!