Runner TrayIcon: Monochrome icon should adapt to windows theme instead of the app theme #44931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@niels9001 Does this make more sense compared to our monochrome icon listen to app theme? |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request changes the Runner's tray icon to adapt to the Windows system theme instead of the PowerToys application theme. This ensures the monochrome tray icon has appropriate contrast regardless of whether the user's system-wide theme differs from their PowerToys app theme.
Changes:
- Modified tray icon initialization and theme change handlers to use
ThemeHelpers::GetSystemTheme()instead oftheme_listener.AppTheme - Extended
ThemeListenerclass to track both app and system themes separately with dedicated handlers - Added iterator validation check in
DelChangedHandlerto prevent undefined behavior
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/runner/tray_icon.cpp | Changed tray icon theme detection from app theme to system theme, registered handler for system theme changes |
| src/common/Themes/theme_listener.h | Added SystemTheme member and separate handler methods for app/system theme changes |
| src/common/Themes/theme_listener.cpp | Implemented separate handler tracking for app/system themes, added iterator validation, improved loop counter types |
| .github/actions/spell-check/expect.txt | Removed unused spell-check entries and normalized casing |
src/common/Themes/theme_listener.cpp
Outdated
Comment on lines
94
to
115
| for (size_t i = 0; i < handles.size(); i++) | ||
| { | ||
| handles[i](); | ||
| } | ||
|
|
||
| // Call app theme specific handlers | ||
| if (appThemeChanged) | ||
| { | ||
| for (size_t i = 0; i < appThemeHandles.size(); i++) | ||
| { | ||
| appThemeHandles[i](); | ||
| } | ||
| } | ||
|
|
||
| // Call system theme specific handlers | ||
| if (systemThemeChanged) | ||
| { | ||
| for (size_t i = 0; i < systemThemeHandles.size(); i++) | ||
| { | ||
| systemThemeHandles[i](); | ||
| } | ||
| } |
There was a problem hiding this comment.
The handler vectors (handles, appThemeHandles, systemThemeHandles) are being accessed from both the background thread (_checkTheme) and the main thread (Add/Del methods) without any synchronization. This creates a race condition where handlers could be added or removed while the background thread is iterating over the vectors, potentially causing crashes or undefined behavior. Consider adding a mutex to protect access to these vectors.
Collaborator
YES! It should not listen to app theme at all, but only to system theme.. if the taskbar is dark, it should render white. if it's light, it should render black, and can totally ignore how PT is themed |
lei9444
approved these changes
Jan 23, 2026
vanzue
added a commit
that referenced
this pull request
Jan 26, 2026
…d of the app theme (#44931) <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request As title <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [X] Closes: #44891 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed ============ System light + App Light <img width="903" height="239" alt="image" src="https://github.com/user-attachments/assets/581606fb-99b5-4df9-a520-545a0c04676c" /> ============ System Light + App Dark <img width="991" height="239" alt="image" src="https://github.com/user-attachments/assets/822009e9-57cf-452b-b3aa-f1cbc25883f8" /> ============ System Dark + App Light <img width="932" height="236" alt="image" src="https://github.com/user-attachments/assets/98a56d48-31f0-4f75-95a4-8c7dc83c3866" /> ============ System Dark + App Dark <img width="903" height="236" alt="image" src="https://github.com/user-attachments/assets/2500a0d5-6b27-403e-89b4-69b7d3b91e79" /> ============
yeelam-gordon
pushed a commit
that referenced
this pull request
Jan 31, 2026
…d of the app theme (#44931) <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request As title <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [X] Closes: #44891 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed ============ System light + App Light <img width="903" height="239" alt="image" src="https://github.com/user-attachments/assets/581606fb-99b5-4df9-a520-545a0c04676c" /> ============ System Light + App Dark <img width="991" height="239" alt="image" src="https://github.com/user-attachments/assets/822009e9-57cf-452b-b3aa-f1cbc25883f8" /> ============ System Dark + App Light <img width="932" height="236" alt="image" src="https://github.com/user-attachments/assets/98a56d48-31f0-4f75-95a4-8c7dc83c3866" /> ============ System Dark + App Dark <img width="903" height="236" alt="image" src="https://github.com/user-attachments/assets/2500a0d5-6b27-403e-89b4-69b7d3b91e79" /> ============
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
As title
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
============ System light + App Light
============ System Light + App Dark
============ System Dark + App Light
============ System Dark + App Dark