Misc CI fixes and Move Search-R1 to contrib #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request accomplishes two main objectives: moving the Search-R1 recipe implementation from examples to the contrib directory, and introducing miscellaneous CI improvements to support workflow testing with different dependency configurations.
Key Changes:
- Migrates Search-R1 recipe to
contrib/recipes/search_r1/with complete implementation files including agent code, retrieval server, training scripts, and documentation - Adds a new "next" test matrix setup in CI workflows to test with upgraded dependencies
- Enhances the examples README with a dedicated workflow status table for better CI visibility
Reviewed changes
Copilot reviewed 6 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/README.md | Adds a new section displaying raw workflow statuses for all example projects with a comprehensive table of workflow badges |
| contrib/recipes/search_r1/train.sh | Training script for Search-R1 with GRPO configuration and model parameters |
| contrib/recipes/search_r1/search_r1_agent.py | Main agent implementation with training/validation rollout logic and reward scoring |
| contrib/recipes/search_r1/retrieval_server.py | FastAPI-based retrieval server supporting BM25 and dense retrieval methods |
| contrib/recipes/search_r1/retrieval_launch.sh | Shell script to launch the retrieval server with specified configurations |
| contrib/recipes/search_r1/qa_em.py | Evaluation metrics implementation for exact match scoring |
| contrib/recipes/search_r1/data_process.sh | Setup script for conda environment and data/index downloads |
| contrib/recipes/search_r1/README.md | Documentation with version compatibility update (v0.1.2) |
| contrib/CODEOWNERS | Adds code ownership for the search_r1 recipe directory |
| agentlightning/verl/entrypoint.py | Moves imports inside main function to avoid potential circular import issues |
| .github/workflows/tests.yml | Adds "next" setup option to lint matrix for testing with latest dependencies |
| .github/workflows/examples-chartqa.yml | Adds scheduled runs, repository dispatch support, and dynamic run naming |
Comments suppressed due to low confidence (1)
contrib/recipes/search_r1/README.md:5
- The project name should use consistent capitalization. Based on the repository naming convention, it should be 'agent-lightning' (lowercase) rather than 'Agent-lightning' to maintain consistency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
examples/README.md
Outdated
| *NOTE: CI status avoids taking any workflow running with latest dependencies into account. That's why we reference the corresponding `badge-*` workflows instead. Each example's own README also displays its `examples-*` workflow status whenever the project is maintained by CI.* | ||
| ## `examples-*` workflow status | ||
|
|
||
| CI status above avoids taking any workflow running with latest dependencies into account. That's why we reference the corresponding `badge-*` workflows instead. The following table displays the raw `examples-*` workflow status whenever the project is maintained by CI.* |
There was a problem hiding this comment.
The sentence ends with an asterisk that appears to be a leftover from the previous note format. This asterisk should be removed as it serves no purpose in the current context.
Suggested change
| CI status above avoids taking any workflow running with latest dependencies into account. That's why we reference the corresponding `badge-*` workflows instead. The following table displays the raw `examples-*` workflow status whenever the project is maintained by CI.* | |
| CI status above avoids taking any workflow running with latest dependencies into account. That's why we reference the corresponding `badge-*` workflows instead. The following table displays the raw `examples-*` workflow status whenever the project is maintained by CI. |
Contributor
Author
|
/ci |
|
🚀 CI Watcher for correlation id-3648929530-mj3trpxg triggered by comment 3648929530
✅ All runs completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.