Skip to content

Fix printing the last day in a 400 year cycle. #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BillyONeal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix printing the last day in a 400 year cycle. #1767

BillyONeal wants to merge 1 commit into from
+10 −0

Conversation

@BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Sep 19, 2023

This was reported to me by "Jag S" over email trying to print 2000-12-31. The cause appears very similar to https://github.com/microsoft/cpprestsdk/pull/1550/files/198b034679cf7f962e242977b99ea5c63ad9eb03

I think this will cause a denial of service bug similar to the last day 365 one in the year 2400.
@BillyONeal
Fix printing the last day in a 400 year cycle.
857ebe0 
This was reported to me by "Jag S" over email trying to print 2000-12-31. The cause appears very similar to https://github.com/microsoft/cpprestsdk/pull/1550/files/198b034679cf7f962e242977b99ea5c63ad9eb03

I think this will cause a denial of service bug similar to the last day 365 one in the year 2400.
@baptistemcn
Copy link

baptistemcn commented Sep 20, 2023

Member of the team of "Jag S" here, Thank you very much !
@BillyONeal BillyONeal mentioned this pull request May 5, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@BillyONeal @baptistemcn