Skip to content

Improve README#47

Merged
aeschli merged 2 commits intomicrosoft:mainfrom
Marcono1234:patch-1
Oct 25, 2021
Merged

Improve README#47
aeschli merged 2 commits intomicrosoft:mainfrom
Marcono1234:patch-1

Conversation

@Marcono1234
Copy link
Copy Markdown
Contributor

@Marcono1234 Marcono1234 commented Aug 29, 2021

  • Add missing type definition for JSONPath; matching the content of src/main.ts
  • Consistently use 4 spaces as indentation for code blocks
@ghost
Copy link
Copy Markdown

ghost commented Aug 29, 2021

CLA assistant check
All CLA requirements met.

export declare function getLocation(text: string, position: number): Location;

export declare type Segment = string | number;
export declare type JSONPath = Segment[];
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely sure if declare is needed here; the README does not seem to use it consistently.

@aeschli aeschli merged commit 81825b0 into microsoft:main Oct 25, 2021
@aeschli aeschli self-assigned this Oct 25, 2021
@aeschli aeschli added this to the October 2021 milestone Oct 25, 2021
@aeschli
Copy link
Copy Markdown
Contributor

aeschli commented Oct 25, 2021

Thanks a lot, @Marcono1234 !

@Marcono1234 Marcono1234 deleted the patch-1 branch October 25, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants