Skip to content

Users/mbarbour/update for async add component#644

Merged
MattB-msft merged 17 commits intomainfrom
users/mbarbour/updateForAsyncAddComponent
May 23, 2025
Merged

Users/mbarbour/update for async add component#644
MattB-msft merged 17 commits intomainfrom
users/mbarbour/updateForAsyncAddComponent

Conversation

@MattB-msft
Copy link
Copy Markdown
Member

This pull request introduces support for running the "add-solution-component" operation asynchronously by adding a new input parameter and updating the related code and tests. Additionally, it updates a dependency version in package.json.

Feature Addition: Asynchronous Operation Support

Dependency Update

  • package.json: Updated the version of @microsoft/powerplatform-cli-wrapper from ^0.1.129 to ^0.1.134.
@MattB-msft MattB-msft requested review from Copilot and tehcrashxor May 22, 2025 17:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for running the add-solution-component action asynchronously by introducing a new run-asynchronously input, updating related code paths and tests, and bumping a CLI-wrapper dependency.

  • Introduced run-asynchronously input in action.yml with default false
  • Wired the new input through actionLaunch.ts and index.ts
  • Updated tests to include the new input and bumped @microsoft/powerplatform-cli-wrapper version

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
add-solution-component/action.yml Added run-asynchronously input with default false
src/actions/add-solution-component/actionLaunch.ts Set default INPUT_RUN-ASYNCHRONOUSLY env var
src/actions/add-solution-component/index.ts Passed new run-asynchronously input to addSolutionComponent
src/test/addSolutionComponent.test.ts Updated test parameters to include the new input
package.json Bumped @microsoft/powerplatform-cli-wrapper to ^0.1.134
Comments suppressed due to low confidence (2)

src/actions/add-solution-component/index.ts:34

  • [nitpick] Using async as a property name is ambiguous and shadows the async keyword. Consider renaming it to runAsynchronously or similar to match the input name and improve clarity.
async: parameterMap['run-asynchronously'],

src/test/addSolutionComponent.test.ts:46

  • Tests currently only cover the default false case. Add a test scenario where run-asynchronously is set to true to verify asynchronous execution paths.
+            async: { name: 'run-asynchronously', required: false, defaultValue: 'false' }
MattB-msft and others added 3 commits May 23, 2025 17:36
@MattB-msft MattB-msft enabled auto-merge (squash) May 23, 2025 19:31
@MattB-msft MattB-msft merged commit 51f663e into main May 23, 2025
5 checks passed
@MattB-msft MattB-msft deleted the users/mbarbour/updateForAsyncAddComponent branch May 23, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants