Skip to content

Mention dependency of codeDescription on code#830

Merged
dbaeumer merged 1 commit intomicrosoft:mainfrom
dc-mak:patch-1
Oct 19, 2021
Merged

Mention dependency of codeDescription on code#830
dbaeumer merged 1 commit intomicrosoft:mainfrom
dc-mak:patch-1

Conversation

@dc-mak
Copy link
Copy Markdown
Contributor

@dc-mak dc-mak commented Oct 11, 2021 •
edited
Loading

This was, in retrospect, obvious, but took me a while to figure out.

vscode-languageserver-node/client/src/common/protocolConverter.ts

Lines 269 to 272 in d5b8fbe

function asDiagnostic(diagnostic: ls.Diagnostic): code.Diagnostic {
let result = new ProtocolDiagnostic(asRange(diagnostic.range), diagnostic.message, asDiagnosticSeverity(diagnostic.severity), diagnostic.data);
if (diagnostic.code !== undefined) {
if (ls.CodeDescription.is(diagnostic.codeDescription)) {

@dbaeumer dbaeumer merged commit c605d75 into microsoft:main Oct 19, 2021
@dc-mak dc-mak deleted the patch-1 branch October 20, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@dc-mak @dbaeumer