Skip to content

feat: --packageManager#1226

Open
Mopsgamer wants to merge 14 commits intomicrosoft:mainfrom
Mopsgamer:impr-pm
Open

feat: --packageManager#1226
Mopsgamer wants to merge 14 commits intomicrosoft:mainfrom
Mopsgamer:impr-pm

Conversation

@Mopsgamer
Copy link
Copy Markdown

@Mopsgamer Mopsgamer commented Nov 25, 2025

This PR is aimed at further addressing issues with package managers. It introduces a distinction between different package managers by creating an internal API.

This internal API could be used to build a public API, but that is not part of my plans.

Note

It should also be noted that the new --packageManager flag could replace the existing --yarn, --no-yarn, and --dependencies options in any upcoming major release.

Removing the deprecated API is also not part of my plans. This PR makes minor changes that could potentially break something, and in such cases patches should be created. I am willing to help with those patches.

@Mopsgamer
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@Mopsgamer
Copy link
Copy Markdown
Author

Adding a new flag might be useless since the resolution in a normal vsce implementation should work similarly to Node regardless of the package manager. This PR should only be considered a refactor. It is needed to get rid of old flags, and will probably need to be removed itself eventually after all node_modules-compatible package managers are working correctly with vsce. And likely, fixing vsce would be a better solution.

Since this is a refactor, it's easier to work with it to fix vsce.

@Stoorx
Copy link
Copy Markdown

Stoorx commented Mar 10, 2026

Up!

@flying-sheep
Copy link
Copy Markdown

would this PR fix #432?

@Mopsgamer
Copy link
Copy Markdown
Author

@flying-sheep

This PR should only be considered a refactor.

There are no functional fixes included here; this PR is strictly an architectural refactor. Others are welcome to implement fixes on top of this layer.

@flying-sheep
Copy link
Copy Markdown

still probably makes it much easier to do just that. thank you, let’s hope it gets in soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants