You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is aimed at further addressing issues with package managers. It introduces a distinction between different package managers by creating an internal API.
This internal API could be used to build a public API, but that is not part of my plans.
Note
It should also be noted that the new --packageManager flag could replace the existing --yarn, --no-yarn, and --dependencies options in any upcoming major release.
Removing the deprecated API is also not part of my plans. This PR makes minor changes that could potentially break something, and in such cases patches should be created. I am willing to help with those patches.
Adding a new flag might be useless since the resolution in a normal vsce implementation should work similarly to Node regardless of the package manager. This PR should only be considered a refactor. It is needed to get rid of old flags, and will probably need to be removed itself eventually after all node_modules-compatible package managers are working correctly with vsce. And likely, fixing vsce would be a better solution.
Since this is a refactor, it's easier to work with it to fix vsce.
There are no functional fixes included here; this PR is strictly an architectural refactor. Others are welcome to implement fixes on top of this layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is aimed at further addressing issues with package managers. It introduces a distinction between different package managers by creating an internal API.
This internal API could be used to build a public API, but that is not part of my plans.
Note
It should also be noted that the new
--packageManagerflag could replace the existing--yarn,--no-yarn, and--dependenciesoptions in any upcoming major release.Removing the deprecated API is also not part of my plans. This PR makes minor changes that could potentially break something, and in such cases patches should be created. I am willing to help with those patches.