Skip to content

feat: warn users about missing LICENSE #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaomoreno merged 7 commits into from
Oct 13, 2021
Merged

feat: warn users about missing LICENSE #628

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
90d6112
feat:warn users about missing LICENSE
Andrewnt219 Oct 12, 2021
e92377b
updated expectedLicenseName default name
Andrewnt219 Oct 12, 2021
1f867a6
fixed failling test
Andrewnt219 Oct 12, 2021
f23b150
Update src/package.ts
joaomoreno Oct 13, 2021
fd7ce1c
Update src/package.ts
joaomoreno Oct 13, 2021
4a3ec12
Update src/package.ts
joaomoreno Oct 13, 2021
bad07a4
Update src/package.ts
joaomoreno Oct 13, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/package.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,7 @@ export class ChangelogProcessor extends MarkdownProcessor {

class LicenseProcessor extends BaseProcessor {
private didFindLicense = false;
private expectedLicenseName: string;
filter: (name: string) => boolean;

constructor(manifest: Manifest) {
Expand All @@ -821,8 +822,10 @@ class LicenseProcessor extends BaseProcessor {
const match = /^SEE LICENSE IN (.*)$/.exec(manifest.license || '');

if (!match || !match[1]) {
this.expectedLicenseName = 'LICENSE.md or LICENSE.txt';
this.filter = name => /^extension\/license(\.(md|txt))?$/i.test(name);
} else {
this.expectedLicenseName = match[1];
const regexp = new RegExp('^extension/' + match[1] + '$');
this.filter = regexp.test.bind(regexp);
}
Expand All @@ -848,6 +851,16 @@ class LicenseProcessor extends BaseProcessor {

return Promise.resolve(file);
}

async onEnd(): Promise<void> {
if (!this.didFindLicense) {
util.log.warn(`${this.expectedLicenseName} not found`);

if (!/^y$/i.test(await util.read('Do you want to continue? [y/N] '))) {
throw new Error('Aborted');
}
}
}
}

class IconProcessor extends BaseProcessor {
Expand Down