Fixes feedback widget appears wrong when invoked from command palette#103738
Merged
sbatten merged 3 commits intomicrosoft:mainfrom Oct 27, 2021
Merged
Fixes feedback widget appears wrong when invoked from command palette#103738sbatten merged 3 commits intomicrosoft:mainfrom
sbatten merged 3 commits intomicrosoft:mainfrom
Conversation
Member
|
@jeanp413 thanks for this PR, sorry its taken a while to get around to it. the approach looks good, would you mind updating the branch to resolve conflicts and then I can test and merge this |
Contributor
Author
|
@sbatten PR updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feedback widget needed an anchor element to position itself so when the "Send Feedback" status bar entry is hidden it throws an error.
To fix it I just absolute positioned it (similar to the notification center).
This PR fixes #99735