Skip to content

Add tooltip for keybinding#134438

Merged
TylerLeonhardt merged 1 commit intomicrosoft:mainfrom
Suven-p:languageSelectionTooltip
Oct 7, 2021
Merged

Add tooltip for keybinding#134438
TylerLeonhardt merged 1 commit intomicrosoft:mainfrom
Suven-p:languageSelectionTooltip

Conversation

@Suven-p
Copy link
Copy Markdown
Contributor

@Suven-p Suven-p commented Oct 5, 2021

This PR fixes #133655

Output with mouse cursor hidden:
With default keybinding:
default_keybinding

With changed keybinding:
cutom_keybinding
@TylerLeonhardt TylerLeonhardt added this to the October 2021 milestone Oct 5, 2021
@isidorn
Copy link
Copy Markdown
Collaborator

isidorn commented Oct 6, 2021

Looks good. Thanks for this PR 👏
Leaving up to @TylerLeonhardt to merge.
TylerLeonhardt
TylerLeonhardt approved these changes Oct 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM awesome work :)
@TylerLeonhardt TylerLeonhardt merged commit 262cc6e into microsoft:main Oct 7, 2021
@Suven-p Suven-p deleted the languageSelectionTooltip branch October 7, 2021 05:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@Suven-p @isidorn @TylerLeonhardt