Skip to content

vscode-dts: Fix typedoc for WebviewPanel.dispose()#289071

Merged
mjbvz merged 1 commit intomicrosoft:mainfrom
hkleungai:update-typedoc-for-WebviewPanel-dispose
Jan 20, 2026
Merged

vscode-dts: Fix typedoc for WebviewPanel.dispose()#289071
mjbvz merged 1 commit intomicrosoft:mainfrom
hkleungai:update-typedoc-for-WebviewPanel-dispose

Conversation

@hkleungai
Copy link
Copy Markdown
Contributor

Sync the change from DefinitelyTyped/DefinitelyTyped#74140 back to this repo.

This change can be justified by the source code from src/vs/workbench/api/common/extHostWebviewPanels.ts.

public override dispose() {
  if (this.#isDisposed) {
    return;
  }

  this.#isDisposed = true;
  this.#onDidDispose.fire();

  this.#proxy.$disposeWebview(this.#handle);
  this.#webview.dispose();

  super.dispose();
}
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 20, 2026
@mjbvz mjbvz enabled auto-merge January 20, 2026 19:05
@mjbvz mjbvz merged commit 7dc2938 into microsoft:main Jan 20, 2026
26 of 28 checks passed
@hkleungai hkleungai deleted the update-typedoc-for-WebviewPanel-dispose branch January 21, 2026 01:43
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Mar 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants