vscode-dts: Add LineCommentConfig interface & update lineComment#289457
Merged
aiday-mar merged 3 commits intomicrosoft:mainfrom Feb 5, 2026
Merged
vscode-dts: Add LineCommentConfig interface & update lineComment#289457aiday-mar merged 3 commits intomicrosoft:mainfrom
aiday-mar merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
|
Ping @aeschli, @aiday-mar Can we get this merged please. There is no reason this PR needs to wait any longer. The changed code is already in production from PR #243283. We just need to update the overall vscode-dts to reflect this change that is nearly 8 months old. This is a really necessary change so that the DefinitelyTyped package can auto-update, and all extension developers can get the updated types. Fixes DefinitelyTyped/DefinitelyTyped#74372 and #290146 |
aiday-mar
previously approved these changes
Feb 2, 2026
aiday-mar
previously approved these changes
Feb 3, 2026
Contributor
|
@alexr00 could I ask for a review on this PR? Thanks! |
mjbvz
reviewed
Feb 3, 2026
Contributor
|
I removed the null type on the lineComment, so this should be ready to merge I think |
mjbvz
approved these changes
Feb 4, 2026
alexr00
approved these changes
Feb 5, 2026
| */ | ||
| comment: string; | ||
| /** | ||
| * Whether the comment token should not be indented and placed at the first column. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Whether the comment token should not be indented and placed at the first column. | |
| * Whether the comment token should not be indented and instead placed at the first column. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essentially a followup on a previous PR #243283.