Skip to content

fix: add missing closing '>' in keybinding placeholder in accessible view navigation hint#295412

Merged
meganrogge merged 2 commits intomicrosoft:mainfrom
Vedag812:fix/accessible-view-keybinding-placeholder
Feb 17, 2026
Merged

fix: add missing closing '>' in keybinding placeholder in accessible view navigation hint#295412
meganrogge merged 2 commits intomicrosoft:mainfrom
Vedag812:fix/accessible-view-keybinding-placeholder

Conversation

@Vedag812
Copy link
Copy Markdown
Contributor

Fix: Add missing closing > in keybinding placeholder in accessible view navigation hint

Fixes #295411

Problem

In _navigationHint(), the first <keybinding:...> placeholder was missing its closing > delimiter:

`<keybinding:${AccessibilityCommandId.ShowNext}`      // missing >
`<keybinding:${AccessibilityCommandId.ShowPrevious}>`  // correct

This caused resolveContentAndKeybindingItems() to not recognize the placeholder, so screen reader users would see raw placeholder text instead of the resolved keybinding label for "Show Next Item".

Fix

One-character fix — added the missing >:

- `<keybinding:${AccessibilityCommandId.ShowNext}`
+ `<keybinding:${AccessibilityCommandId.ShowNext}>`

Testing

  • Verified that the second placeholder (ShowPrevious) already has the correct > delimiter
  • The fix makes the first placeholder syntactically consistent with the second
…view navigation hint

The _navigationHint() method had a keybinding placeholder missing its
closing '>' delimiter. This caused resolveContentAndKeybindingItems()
to not recognize the placeholder, resulting in raw placeholder text
being shown to screen reader users instead of the resolved keybinding.

Fixes microsoft#295411
@Vedag812
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@meganrogge meganrogge added this to the February 2026 milestone Feb 17, 2026
@meganrogge meganrogge enabled auto-merge (squash) February 17, 2026 17:56
Copy link
Copy Markdown
Collaborator

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Vedag812
Copy link
Copy Markdown
Contributor Author

thanks!
Your welcome😊

@Vedag812
Copy link
Copy Markdown
Contributor Author

thanks!
Your welcome😊

Mam is the pull request accepted?
Its showing here checks required still?

@meganrogge meganrogge merged commit 2ce64e0 into microsoft:main Feb 17, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants