Bump xterm to fix kitty keyboard protocol#299833
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the xterm.js dependency set used by VS Code (desktop, remote server, and web) to pick up an upstream fix for the kitty keyboard protocol that regressed key handling (notably Ctrl+C) in the integrated terminal with fish.
Changes:
- Bump
@xterm/xtermfrom6.1.0-beta.168→6.1.0-beta.169across the repo’s relevant package manifests. - Bump associated
@xterm/addon-*packages to the matchingbeta.169set (and@xterm/addon-webglto0.20.0-beta.168). - Update the corresponding
package-lock.jsonfiles to reflect the new resolved versions, integrity hashes, and peer dependency ranges.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Bumps xterm and addon dependency versions for the main (desktop) build. |
package-lock.json |
Updates lockfile entries for the new xterm/addon versions in the main build. |
remote/package.json |
Bumps xterm and addon dependency versions for the remote server (vscode-reh). |
remote/package-lock.json |
Updates lockfile entries for the new xterm/addon versions in the remote server build. |
remote/web/package.json |
Bumps xterm and addon dependency versions for the web build (vscode-web). |
remote/web/package-lock.json |
Updates lockfile entries for the new xterm/addon versions in the web build. |
Files not reviewed (2)
- remote/package-lock.json: Language not supported
- remote/web/package-lock.json: Language not supported
|
@anthonykim1 red CI |
|
@anthonykim1 this seems to be widespread in latest vscode stable versions. when i can expect the fix to be released. |
|
@Ankit-PG-Grad Hello, This has been merged, so on the next vscode insiders, you will be able to see and verify the fix. Accessible through: |
|
yup this seems to be the insider release. |
Resolves: #295372 and #298463
Take in upstream: xtermjs/xterm.js#5737
/cc @meganrogge @Tyriar