Skip to content

Bump xterm to fix kitty keyboard protocol#299833

Merged
anthonykim1 merged 3 commits intomainfrom
anthonykim1/fixFishCtrlC
Mar 8, 2026
Merged

Bump xterm to fix kitty keyboard protocol#299833
anthonykim1 merged 3 commits intomainfrom
anthonykim1/fixFishCtrlC

Conversation

@anthonykim1
Copy link
Copy Markdown
Contributor

Resolves: #295372 and #298463
Take in upstream: xtermjs/xterm.js#5737

/cc @meganrogge @Tyriar

@anthonykim1 anthonykim1 added this to the 1.112.0 milestone Mar 6, 2026
@anthonykim1 anthonykim1 self-assigned this Mar 6, 2026
Copilot AI review requested due to automatic review settings March 6, 2026 18:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the xterm.js dependency set used by VS Code (desktop, remote server, and web) to pick up an upstream fix for the kitty keyboard protocol that regressed key handling (notably Ctrl+C) in the integrated terminal with fish.

Changes:

  • Bump @xterm/xterm from 6.1.0-beta.1686.1.0-beta.169 across the repo’s relevant package manifests.
  • Bump associated @xterm/addon-* packages to the matching beta.169 set (and @xterm/addon-webgl to 0.20.0-beta.168).
  • Update the corresponding package-lock.json files to reflect the new resolved versions, integrity hashes, and peer dependency ranges.

Reviewed changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Bumps xterm and addon dependency versions for the main (desktop) build.
package-lock.json Updates lockfile entries for the new xterm/addon versions in the main build.
remote/package.json Bumps xterm and addon dependency versions for the remote server (vscode-reh).
remote/package-lock.json Updates lockfile entries for the new xterm/addon versions in the remote server build.
remote/web/package.json Bumps xterm and addon dependency versions for the web build (vscode-web).
remote/web/package-lock.json Updates lockfile entries for the new xterm/addon versions in the web build.
Files not reviewed (2)
  • remote/package-lock.json: Language not supported
  • remote/web/package-lock.json: Language not supported
@meganrogge
Copy link
Copy Markdown
Collaborator

@anthonykim1 red CI

@anthonykim1 anthonykim1 merged commit 4fb8242 into main Mar 8, 2026
85 of 86 checks passed
@anthonykim1 anthonykim1 deleted the anthonykim1/fixFishCtrlC branch March 8, 2026 07:03
@Ankit-PG-Grad
Copy link
Copy Markdown

@anthonykim1 this seems to be widespread in latest vscode stable versions. when i can expect the fix to be released.

@anthonykim1
Copy link
Copy Markdown
Contributor Author

@Ankit-PG-Grad Hello, This has been merged, so on the next vscode insiders, you will be able to see and verify the fix.
Please note insiders is different than the stable (vscode with blue icon) you normally see.

Accessible through:
Insiders build

@Ankit-PG-Grad
Copy link
Copy Markdown

yup this seems to be the insider release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants