Skip to content

Support terminal creation on web worker extension host when there's remote authority#300897

Merged
meganrogge merged 1 commit intomicrosoft:mainfrom
jeanp413:jp/back-limpet
Mar 12, 2026
Merged

Support terminal creation on web worker extension host when there's remote authority#300897
meganrogge merged 1 commit intomicrosoft:mainfrom
jeanp413:jp/back-limpet

Conversation

@jeanp413
Copy link
Copy Markdown
Contributor

Fixes #300895

Copilot AI review requested due to automatic review settings March 11, 2026 19:47
@jeanp413
Copy link
Copy Markdown
Contributor Author

cc @meganrogge @Tyriar could you take a look 🙏

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables vscode.window.createTerminal* from the web worker extension host when running in a web context that has a remote authority (eg. VS Code Web connected to a remote), addressing the “Not supported” error in that scenario.

Changes:

  • Injects IExtHostInitDataService into WorkerExtHostTerminalService to detect whether a remote authority exists.
  • Allows createTerminal/createTerminalFromOptions in the worker ext host only when initData.remote.authority is present; otherwise continues throwing NotSupportedError.

You can also share your feedback on Copilot code review. Take the survey.

@jeanp413
Copy link
Copy Markdown
Contributor Author

Recording 2026-03-11 at 14 54 17

Copy link
Copy Markdown
Contributor

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but lgtm

Copy link
Copy Markdown
Collaborator

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meganrogge meganrogge enabled auto-merge (squash) March 12, 2026 00:42
@meganrogge meganrogge merged commit 422d296 into microsoft:main Mar 12, 2026
21 of 22 checks passed
@jeanp413 jeanp413 deleted the jp/back-limpet branch March 12, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants