fix: handle FastAPI >= 0.137 lazy router inclusion (_IncludedRouter)#64
Open
fsecada01 wants to merge 1 commit into
Open
fix: handle FastAPI >= 0.137 lazy router inclusion (_IncludedRouter)#64fsecada01 wants to merge 1 commit into
fsecada01 wants to merge 1 commit into
Conversation
FastAPI 0.137 introduced lazy router inclusion: include_router() now appends an internal _IncludedRouter node (a BaseRoute with no .path) to app.routes instead of eagerly flattening included routes. The toolbar iterated app.routes assuming every entry was a concrete route, so: - matched_route() called route.matches() and the RoutesPanel template read route.path on _IncludedRouter nodes, raising AttributeError: '_IncludedRouter' object has no attribute 'path' on every request once the toolbar was active. Adds utils.iter_effective_routes(), which expands _IncludedRouter nodes into their effective, correctly-prefixed route contexts (each exposing .path/.name/.methods/.endpoint and a working .matches) and is a no-op on older FastAPI. matched_route() and RoutesPanel now flatten via this helper; matched_route() returns the underlying original_route for expanded contexts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
fsecada01
force-pushed
the
fix/fastapi-0137-included-router
branch
from
91769a6 to
8c6d16a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FastAPI 0.137 introduced lazy router inclusion: include_router() now appends an internal _IncludedRouter node (a BaseRoute with no .path) to app.routes instead of eagerly flattening included routes. The toolbar iterated app.routes assuming every entry was a concrete route, so:
Adds utils.iter_effective_routes(), which expands _IncludedRouter nodes into their effective, correctly-prefixed route contexts (each exposing .path/.name/.methods/.endpoint and a working .matches) and is a no-op on older FastAPI. matched_route() and RoutesPanel now flatten via this helper; matched_route() returns the underlying original_route for expanded contexts.