fxa: fix sync key invariant checks so they are only done after we've …#7458
Open
mhammond wants to merge 1 commit into
Open
fxa: fix sync key invariant checks so they are only done after we've …#7458mhammond wants to merge 1 commit into
mhammond wants to merge 1 commit into
Conversation
mhammond
force-pushed
the
push-lrvnyvpkysot
branch
from
5db108d to
7d4652f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…merged all keys
The current code will
report_errorthat we are missing the sync key when doing scope upgrades. We aren't and things work fine, but thereport_errorcalls are false positives that are likely to hit vpn flows. We could maybe uplift, but it's not strictly necessary.