Skip to content

[code_review] Replace comment order with severity in code review tools#5118

Draft
suhaibmujahid wants to merge 1 commit into
mozilla:masterfrom
suhaibmujahid:severity-classes
Draft

[code_review] Replace comment order with severity in code review tools#5118
suhaibmujahid wants to merge 1 commit into
mozilla:masterfrom
suhaibmujahid:severity-classes

Conversation

@suhaibmujahid

Copy link
Copy Markdown
Member

Resolves #5047

Refactored code review comment handling to use a 'severity' field (1-3) instead of 'order' for prioritizing comments.

Refactored code review comment handling to use a 'severity' field (1-3) instead of 'order' for prioritizing comments.
@suhaibmujahid suhaibmujahid changed the title Replace comment order with severity in code review tools Jul 7, 2025
@suhaibmujahid

Copy link
Copy Markdown
Member Author
--------------------
Variant Name: with-severity
--------------------
New Comments: 441
New Valid Comments: 49
New Invalid Comments: 95
New Unevaluated Comments: 296
--------------------
Old Comments: 277
Old Valid Comments: 84
Old Invalid Comments: 191
--------------------
Recalled comments: 56.317689530685925
Recalled valid comments: 58.333333333333336
Recalled invalid comments: 56.02094240837696
--------------------
Missed valid comments: 41.66666666666667
Missed invalid comments: 43.97905759162304

Limit to S1 only:

--------------------
Variant Name: with-severity
--------------------
New Comments: 27
New Valid Comments: 5
New Invalid Comments: 9
New Unevaluated Comments: 13
--------------------
Old Comments: 277
Old Valid Comments: 84
Old Invalid Comments: 191
--------------------
Recalled comments: 5.054151624548736
Recalled valid comments: 5.952380952380952
Recalled invalid comments: 4.712041884816754
--------------------
Missed valid comments: 94.04761904761905
Missed invalid comments: 95.28795811518324

Limit to S1 and S2:

--------------------
Variant Name: with-severity
--------------------
New Comments: 242
New Valid Comments: 31
New Invalid Comments: 65
New Unevaluated Comments: 146
--------------------
Old Comments: 277
Old Valid Comments: 84
Old Invalid Comments: 191
--------------------
Recalled comments: 37.545126353790614
Recalled valid comments: 36.904761904761905
Recalled invalid comments: 38.21989528795812
--------------------
Missed valid comments: 63.095238095238095
Missed invalid comments: 61.78010471204188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant