Use robustcheckout for pulling#5397
Draft
marco-c wants to merge 1 commit into
Draft
Conversation
marco-c
force-pushed
the
robustcheckout
branch
from
6d53a0f to
d9318f6
Compare
Collaborator
Author
|
This is a bit painful on the mocks |
marco-c
force-pushed
the
robustcheckout
branch
from
d9318f6 to
fb84b23
Compare
cgsheeh
approved these changes
Oct 31, 2025
| p.terminate() | ||
| p.wait() | ||
| raise | ||
| p = subprocess.Popen(cmd, cwd=repo_dir) |
Member
There was a problem hiding this comment.
Maybe this is a good time to switch to subprocess.run(cmd, cwd=repo_dir, timeout=180...?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5393