[WIP] Initial implementation of pulse listener#6246
Draft
evgenyrp wants to merge 2 commits into
Draft
Conversation
Notification about run outcomes is out of scope for the listener (mozilla#6261); it will live in the API or a separate service. Drop the SendGrid email sender, the run-polling worker, the get_run API client, and the ThreadPoolExecutor that fed them, along with their settings and deploy config. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@suhaibmujahid this is just to show the idea of a separate simple queue listener that calls the API. It does listen properly, but to test it in integration with the API, I need the build repair agent deployed. It also emails the result to a developer.
The good thing about it is that it does not interfere with the API deployment, and the API stays single-responsibility. All the triggers and result processing live separately. It can be developed and tested separately "microservices" way.
The downside is that we need to manage a separate deployment. It could be a part of the same deployment stack as the API and UI, though.