Remove trailing spaces in activities.json. #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Er, I need to fix the newline at end of file. (Edit: fixed now, by amending commit.) |
I suspect editors like to strip out this trailing whitespace (e.g., from mozilla#53) which activities.py then readds when manipulating the JSON (in mozilla#66). We'll avoid the churn (and annoyance) by not having the trailing whitespace at all. This sets the separators as described in the documentation at https://docs.python.org/2/library/json.html to avoid trailing whitespace when using indent. It also consolidates the JSON-writing configuration into a single place by creating a single JSONEncoder object.
adamroach
approved these changes
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect editors like to strip out this trailing whitespace (e.g.,
from #53) which activities.py then readds when manipulating the JSON
(in #66). We'll avoid the churn (and annoyance) by not having the
trailing whitespace at all.
This sets the separators as described in the documentation at
https://docs.python.org/2/library/json.html to avoid trailing whitespace
when using indent.
It also consolidates the JSON-writing configuration into a single place
by creating a single JSONEncoder object.