Moved check_conf function from xeve_app implementation to xeve API#61
Moved check_conf function from xeve_app implementation to xeve API#61
Conversation
dariusz-f
left a comment
There was a problem hiding this comment.
Looks good.
This change is suggested by FFmpeg community.
|
The idea behind moving implementation of check_conf function from the xeve library client to the xeve library implementation comes from ffmpeg communinty suggestions following code review of our libxeve wrapper implementation for ffmpeg project. |
kpchoi
left a comment
There was a problem hiding this comment.
Please find my comments.
inc/xeve.h
Outdated
| int XEVE_EXPORT xeve_config(XEVE id, int cfg, void * buf, int * size); | ||
| int XEVE_EXPORT xeve_param_default(XEVE_PARAM* param); | ||
| int XEVE_EXPORT xeve_param_ppt(XEVE_PARAM* param, int profile, int preset, int tune); | ||
| int XEVE_EXPORT xeve_check_conf(XEVE_CDSC* cdsc); |
There was a problem hiding this comment.
I'd like to suggest the followings;
- change the "xeve_check_conf()" API name to "xeve_param_check()"
- use "XEVE_PARAM* param" instead of "XEVE_CDSC* cdsc" for input argument, because it would be kinds of utility function for parameter setting.
No description provided.