Merged
Conversation
Added function that sets the value for a given param from XEVE_PARAM struct
dariusz-f
requested changes
Sep 28, 2022
washish
reviewed
Sep 29, 2022
washish
reviewed
Sep 29, 2022
dariusz-f
approved these changes
Sep 29, 2022
washish
approved these changes
Sep 30, 2022
kpchoi
reviewed
Oct 3, 2022
inc/xeve.h
Outdated
Comment on lines
+597
to
+601
| /** Set one parameter by name. | ||
| * @retval 0 on success | ||
| * @retval XEVE_ERR_INVALID_ARGUMENT | ||
| * @retval XEVE_ERR | ||
| */ |
Collaborator
There was a problem hiding this comment.
Currently, we're not using doxygen syntax. How about removing this comments for consistency?
Collaborator
There was a problem hiding this comment.
My recommendation is only for API, not internal comments.
Collaborator
Author
There was a problem hiding this comment.
If everything is OK please merge the PR to the main branch.
…current documenting conventions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added function that sets the value for a given param from XEVE_PARAM struct