fix(core): scope public share theme filter to the download icon#61648
Open
pringelmann wants to merge 1 commit into
Open
fix(core): scope public share theme filter to the download icon#61648pringelmann wants to merge 1 commit into
pringelmann wants to merge 1 commit into
Conversation
pringelmann
requested review from
nfebe and
susnux
and removed request for
a team
pringelmann
force-pushed
the
fix/public-page-menu-global-filter-scope
branch
from
8f7cfb6 to
c7e6895
Compare
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Contributor
|
I stopped the backports of the first PR to prevent a regression. So the backports here will not be so clean. Not sure how best to proceed. I'm happy to unblock the other backports if that helps. |
max-nextcloud
approved these changes
Jun 29, 2026
susnux
reviewed
Jun 29, 2026
susnux
approved these changes
Jun 29, 2026
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
fix/public-page-menu-global-filter-scope
branch
from
c7e6895 to
b68dd67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#59175 added a global + class selector to scope the download-icon color filter to the explicit light/dark theme. Vue's scoped-style compiler drops everything after
:global(...). Sincedata-themesis set on<body>, the filter inverted the entire public share page whenever a theme was enforced. Moving the descendant inside the parens keeps the full selector and limits the filter to the icon.Before:
After:
Checklist
3. to review, feature component)stable32)