Fix ldap:show-remnant sharer column when remnants are disabled#61677
Open
come-nc wants to merge 3 commits into
Open
Fix ldap:show-remnant sharer column when remnants are disabled#61677come-nc wants to merge 3 commits into
come-nc wants to merge 3 commits into
Conversation
come-nc
requested review from
Altahrim,
icewind1991,
leftybournes and
nfebe
and removed request for
a team
blizzz
approved these changes
Jun 30, 2026
…dden Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
When Remnants are considered disabled (see markRemnantsAsDisabled) and shares by disabled users are hidden (see hide_disabled_user_shares) ldap:show-remnants would show all remnants as having no shares. It was also quite slow if users have a lot of shares as it was iterating over all shares from all remnants. Now, validity of shares is not checked anymore by show-remnants. It’s a bit less accurate (a remnant may appear as a sharer even if all its shares are expired) but it’s faster. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Arthur Schiwon <blizzz@arthur-schiwon.de> Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
come-nc
force-pushed
the
fix/fix-show-remnant-shares
branch
from
dfb0b0c to
a874d75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Remnants are considered disabled (see markRemnantsAsDisabled) and shares by disabled users are hidden (see hide_disabled_user_shares) ldap:show-remnants would show all remnants as having no shares. It was also quite slow if users have a lot of shares as it was iterating over all shares from all remnants.
Now, validity of shares is not checked anymore by show-remnants. It’s a bit less accurate (a remnant may appear as a sharer even if all its shares are expired) but it’s faster.
Checklist
3. to review, feature component)stable32)AI (if applicable)