Improve keep extension #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunnckoCore
reviewed
Jun 8, 2022
| return originalFilename; | ||
| } | ||
|
|
||
| // able to get composed extension with multiple dots |
Member
There was a problem hiding this comment.
i remember pretty clearly there was some reason for that, some report or feature or issue.. but i don't remember the reason haha, so we can switch back to just getting the thing after the last dot with Node's builtin and all the drama goes to the trash.
tunnckoCore
reviewed
Jun 8, 2022
| */ | ||
| // slugify to avoid invalid filenames | ||
| // substr to define a maximum | ||
| return `${slugify(name)}.${slugify(ext, {separator: ''})}`.substr(0, 100); |
Member
There was a problem hiding this comment.
we better use filenamify instead.
filenamify(name, { replacement: '-' })there will not be needed for ext, because we can just return path.extname, as per the other comments.
Member
There was a problem hiding this comment.
ooh, that's from the examples dir, lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #856