Skip to content

feat: Node.js#2341

Closed
nodejs-github-bot wants to merge 1 commit into
mainfrom
update-branch
Closed

feat: Node.js#2341
nodejs-github-bot wants to merge 1 commit into
mainfrom
update-branch

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Automated changes by create-pull-request GitHub action

@nodejs-github-bot nodejs-github-bot requested a review from a team January 14, 2026 07:49
Comment thread 20/alpine3.22/Dockerfile
&& rm -rf /tmp/*

ENV YARN_VERSION=1.22.22
ENV YARN_VERSION=0.0.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here 😅

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curl -sSL --compressed https://yarnpkg.com/latest-version works fine on my machine

@SimenB SimenB mentioned this pull request Jan 14, 2026
12 tasks
@SimenB

SimenB commented Jan 14, 2026

Copy link
Copy Markdown
Member

v24.13.0 isn't available for MUSL yet anyways, not sure why the bot opened a PR

@nodejs-github-bot nodejs-github-bot requested a review from a team January 14, 2026 08:08
PeterDaveHello added a commit that referenced this pull request Jan 16, 2026
- Preserve existing YARN_VERSION when running update.sh with -s flag
  instead of leaving template placeholder (0.0.0) in Dockerfiles
- Change build-automation.mjs to skip versions without musl builds
  instead of exiting early, preventing partial updates
- Add condition to workflow to skip PR creation when no versions
  were updated, preventing empty PR titles

Fixes issues seen in PRs #2341, #2347, #2350 where automation produced
Dockerfiles with YARN_VERSION=0.0.0 and/or empty PR titles.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
PeterDaveHello added a commit that referenced this pull request Jan 31, 2026
- Preserve existing YARN_VERSION when running update.sh with -s flag
  instead of leaving template placeholder (0.0.0) in Dockerfiles
- Change build-automation.mjs to skip versions without musl builds
  instead of exiting early, preventing partial updates
- Add condition to workflow to skip PR creation when no versions
  were updated, preventing empty PR titles

Fixes issues seen in PRs #2341, #2347, #2350 where automation produced
Dockerfiles with YARN_VERSION=0.0.0 and/or empty PR titles.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants