Skip to content

docs: describe manual PR image creation#2510

Merged
MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:manual-version-contributing
Jun 8, 2026
Merged

docs: describe manual PR image creation#2510
MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:manual-version-contributing

Conversation

@MikeMcC399

Copy link
Copy Markdown
Contributor

Description

Instructions are added to the CONTRIBUTING document to clarify when it may be necessary to open a PR to create new images manually.

Motivation and Context

Originally the CONTRIBUTING document had no description of the automated process for image creation and it included a blanket invitation for users to submit update PRs.

The hierarchy of PR creation should be:

  1. automated creation
  2. manual creation by team member if automated creation fails
  3. manual creation by other user if all else fails

Testing Details

N/A

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.
@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 19, 2026 11:50
@MikeMcC399 MikeMcC399 requested a review from nschonni May 19, 2026 11:50
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 force-pushed the manual-version-contributing branch 2 times, most recently from 813aad4 to 5d6ad9c Compare May 26, 2026 18:39
@MikeMcC399 MikeMcC399 requested a review from sxa May 27, 2026 10:02
@MikeMcC399 MikeMcC399 force-pushed the manual-version-contributing branch from 5d6ad9c to b80fe5e Compare May 27, 2026 10:04
@MikeMcC399

This comment was marked as resolved.

@MikeMcC399 MikeMcC399 merged commit 554f269 into nodejs:main Jun 8, 2026
2 checks passed
@MikeMcC399 MikeMcC399 deleted the manual-version-contributing branch June 8, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants