Skip to content

Conversation

npm-robot
Copy link
Contributor

v8.5.4 (2022-03-10)

Bug Fixes

Documentation

Dependencies

@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Mar 10, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@ruyadorno ruyadorno added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2022
@nodejs-github-bot

This comment was marked as outdated.

@VoltrexKeyva VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Mar 11, 2022
Copy link
Member

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@ruyadorno ruyadorno added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 14, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/42288
✔  Done loading data for nodejs/node/pull/42288
----------------------------------- PR info ------------------------------------
Title      deps: upgrade npm to 8.5.4 (#42288)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     npm-robot:npm-8.5.4 -> nodejs:master
Labels     npm, fast-track, dont-land-on-v12.x, dont-land-on-v14.x
Commits    1
 - deps: upgrade npm to 8.5.4
Committers 1
 - npm team 
PR-URL: https://github.com/nodejs/node/pull/42288
Fixes: https://github.com/clean
Reviewed-By: Mestery 
Reviewed-By: Rich Trott 
Reviewed-By: Ruy Adorno 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
Reviewed-By: Darshan Sen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42288
Fixes: https://github.com/clean
Reviewed-By: Mestery 
Reviewed-By: Rich Trott 
Reviewed-By: Ruy Adorno 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
Reviewed-By: Darshan Sen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 10 Mar 2022 19:08:49 GMT
   ✔  Approvals: 6
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42288#pullrequestreview-906329579
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42288#pullrequestreview-906361109
   ✔  - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/42288#pullrequestreview-906391279
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42288#pullrequestreview-907016617
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42288#pullrequestreview-907623203
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42288#pullrequestreview-908156194
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-03-11T10:11:42Z: https://ci.nodejs.org/job/node-test-pull-request/42940/
- Querying data for job/node-test-pull-request/42940/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 42288
From https://github.com/nodejs/node
 * branch                  refs/pull/42288/merge -> FETCH_HEAD
✔  Fetched commits as a718ef91f462..3857be55d2bf
--------------------------------------------------------------------------------
[master 0c333a45c3] deps: upgrade npm to 8.5.4
 Author: npm team 
 Date: Thu Mar 10 19:08:45 2022 +0000
 53 files changed, 2306 insertions(+), 1398 deletions(-)
 rewrite deps/npm/lib/utils/otplease.js (68%)
 delete mode 100644 deps/npm/node_modules/gauge/lib/demo.js
 rewrite deps/npm/node_modules/make-fetch-happen/node_modules/lru-cache/bundle/main.js (96%)
 create mode 100644 deps/npm/tap-snapshots/test/lib/commands/doctor.js.test.cjs
 create mode 100644 deps/npm/test/fixtures/tnock.js
 rewrite deps/npm/test/lib/commands/doctor.js (98%)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
deps: upgrade npm to 8.5.4

PR-URL: #42288
Fixes: https://github.com/clean
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Ruy Adorno ruyadorno@github.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

[master 0089a7bb68] deps: upgrade npm to 8.5.4
Author: npm team ops+robot@npmjs.com
Date: Thu Mar 10 19:08:45 2022 +0000
53 files changed, 2306 insertions(+), 1398 deletions(-)
rewrite deps/npm/lib/utils/otplease.js (68%)
delete mode 100644 deps/npm/node_modules/gauge/lib/demo.js
rewrite deps/npm/node_modules/make-fetch-happen/node_modules/lru-cache/bundle/main.js (96%)
create mode 100644 deps/npm/tap-snapshots/test/lib/commands/doctor.js.test.cjs
create mode 100644 deps/npm/test/fixtures/tnock.js
rewrite deps/npm/test/lib/commands/doctor.js (98%)
✖ 0089a7bb68a9edfe89871ed775de26df0ae48640
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✖ 2:7 Fixes must be a GitHub URL. fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/1981430462

@ruyadorno
Copy link
Member

closing in favor of #42382

@ruyadorno ruyadorno closed this Mar 17, 2022
@wraithgar wraithgar deleted the npm-8.5.4 branch June 26, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. npm Issues and PRs related to the npm client dependency or the npm registry.

8 participants