fix: handle comma-separated Notion multi-select filters#4227
Merged
Conversation
✅ Deploy Preview for notionnext-netlify ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying notionnext-org-docs with
|
| Latest commit: |
09fb0c4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d86f567.notionnext-org-docs.pages.dev |
| Branch Preview URL: | https://codex-fix-gallery-tags-filte.notionnext-org-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multi_selectschema fields so text filters are unchangedmulti_select_containsandmulti_select_does_not_containRoot cause
Some Notion payloads encode multi-select tags as a single plain text value like
Tech,Life. The collection filter matcher compared exact values only, socontains Techmissed the page anddoes_not_contain Techcould incorrectly keep it.Checks
npx jest __tests__/lib/notion-data-format.test.js --runInBand --env=nodenpx eslint lib\db\notion\filterCollectionViewData.js __tests__\lib\notion-data-format.test.jsgit diff --check