Skip to content

Warn adduser changes, undeprecate --auth-type, but warn for some values #5149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2022
Merged

Warn adduser changes, undeprecate --auth-type, but warn for some values #5149

merged 2 commits into from
Jul 12, 2022

Conversation

fritzy
Copy link
Contributor

@fritzy fritzy commented Jul 11, 2022

  • feat: notify on adduser of upcoming cmds, login and register
  • feat: deprecate --auth-type=sso/saml/oauth, undeprecate --auth-type
@fritzy fritzy requested a review from a team as a code owner July 11, 2022 23:51
@fritzy
Copy link
Contributor Author

fritzy commented Jul 11, 2022

Please don't squash.
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Jul 12, 2022 •
edited
Loading

found 1 benchmarks with statistically significant performance regressions

  • app-large: no-clean
timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 41.723 ±1.47 20.673 ±0.31 17.245 ±0.15 20.065 ±2.11 2.837 ±0.05 3.060 ±0.03 2.500 ±0.10 11.391 ±0.03 2.260 ±0.01 3.593 ±0.02
#5149 41.297 ±0.84 19.689 ±0.29 17.774 ±0.06 21.202 ±1.03 3.110 ±0.04 3.103 ±0.04 2.489 ±0.03 12.216 ±0.14 2.601 ±0.05 3.781 ±0.21
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 29.568 ±0.31 14.757 ±0.04 12.968 ±0.00 13.440 ±0.26 2.758 ±0.14 2.811 ±0.03 2.498 ±0.03 8.674 ±0.04 2.359 ±0.02 3.396 ±0.30
#5149 31.707 ±0.28 15.169 ±0.02 13.290 ±0.20 14.303 ±0.18 2.853 ±0.05 2.806 ±0.07 2.447 ±0.01 9.229 ±0.12 2.523 ±0.10 3.369 ±0.01
wraithgar
wraithgar reviewed Jul 12, 2022
View reviewed changes
wraithgar
wraithgar approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved w/ one tiny suggestion you can ignore if you want.
@wraithgar wraithgar mentioned this pull request Jul 12, 2022
Merged
@fritzy fritzy force-pushed the fritzy/deprecations branch from 953fe84 to d0cef40 Compare July 12, 2022 18:09
@fritzy fritzy force-pushed the fritzy/deprecations branch from d0cef40 to 9ca41c8 Compare July 12, 2022 18:11
@wraithgar wraithgar merged commit e58f02f into latest Jul 12, 2022
@wraithgar wraithgar deleted the fritzy/deprecations branch July 12, 2022 18:34
@wraithgar wraithgar mentioned this pull request Jul 12, 2022
Closed
@hfaulds hfaulds mentioned this pull request Jul 13, 2022
Closed
@wraithgar wraithgar mentioned this pull request Jul 13, 2022
Merged
@npm-cli-bot npm-cli-bot mentioned this pull request Jul 13, 2022
Merged
This was referenced Oct 22, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@fritzy @npm-cli-bot @wraithgar