Skip to content

fix(arborist): fix bare attribute queries #5248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2022
Merged

fix(arborist): fix bare attribute queries #5248

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1184789
fix: bare attribute queries
darcyclarke Aug 3, 2022
0bb2327
update fix location
darcyclarke Aug 3, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions workspaces/arborist/lib/query-selector-all.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,6 @@ class Results {

// operators for attribute selectors
const attributeOperators = {
// existence of the attribute
'' ({ attr }) {
return Boolean(attr)
},
// attribute value is equivalent
'=' ({ attr, value, insensitive }) {
return attr === value
Expand Down Expand Up @@ -373,6 +369,10 @@ const attributeMatch = (matcher, obj) => {
if (insensitive) {
value = value.toLowerCase()
}
// if we're checking for existence we can return early & avoid attr coersion
if (operator === '') {
return Boolean(obj[attribute])
}
// in case the current object is an array
// then we try to match every item in the array
if (Array.isArray(obj[attribute])) {
Expand Down
6 changes: 6 additions & 0 deletions workspaces/arborist/test/query-selector-all.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ t.test('query-selector-all', async t => {
dependencies: {
lorem: 'latest',
},
scripts: {
test: 'tap',
},
}),
},
foo: {
Expand Down Expand Up @@ -567,6 +570,9 @@ t.test('query-selector-all', async t => {
[':attr(arbitrary, :attr([foo=10000]))', ['bar@2.0.0']],

// attribute matchers
['[scripts]', [
'baz@1.0.0',
]],
['[name]', [
'query-selector-all-tests@1.0.0',
'a@1.0.0',
Expand Down