fix: use hosted-git-info to parse registry urls #5761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to a draft until npm/hosted-git-info#177 is landed and published. |
Previously this was using `new URL` which would fail on some urls that `hosted-git-info` is able to parse. But if we still get a url that can't be parsed, we now set it to be removed from the tree instead of erroring. Fixes: #5278
lukekarrys
force-pushed
the
lk/git-ssh-urls-v8
branch
from
95cedf5 to
9f467d2
Compare
3 tasks
wraithgar
approved these changes
Nov 1, 2022
Merged
halstead
pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Feb 6, 2023
* 16.18.0 (npm 8.19.2) introduced a regression in git+ssh urls - nodejs/node#44992 - npm/cli#5761 https://nodejs.org/ko/blog/release/v16.19.0/ License-Update: Clarify vendored OpenSSL Toolkit is OpenSSL and SSLeay License-Update: JS Foundation -> OpenJS Foundation nodejs/node@e7ed56f Signed-off-by: Tim Orling <tim.orling@konsulko.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
halstead
pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Feb 6, 2023
* 16.18.0 (npm 8.19.2) introduced a regression in git+ssh urls - nodejs/node#44992 - npm/cli#5761 https://nodejs.org/ko/blog/release/v16.19.0/ License-Update: Clarify vendored OpenSSL Toolkit is OpenSSL and SSLeay License-Update: JS Foundation -> OpenJS Foundation nodejs/node@e7ed56f Signed-off-by: Tim Orling <tim.orling@konsulko.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
jpuhlman
pushed a commit
to MontaVista-OpenSourceTechnology/meta-openembedded
that referenced
this pull request
Feb 6, 2023
Source: meta-openembedded MR: 124675 Type: Integration Disposition: Merged from meta-openembedded ChangeID: 278ec08 Description: * 16.18.0 (npm 8.19.2) introduced a regression in git+ssh urls - nodejs/node#44992 - npm/cli#5761 https://nodejs.org/ko/blog/release/v16.19.0/ License-Update: Clarify vendored OpenSSL Toolkit is OpenSSL and SSLeay License-Update: JS Foundation -> OpenJS Foundation nodejs/node@e7ed56f Signed-off-by: Tim Orling <tim.orling@konsulko.com> Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
nmbath
pushed a commit
to victronenergy/meta-openembedded
that referenced
this pull request
Feb 10, 2023
* 16.18.0 (npm 8.19.2) introduced a regression in git+ssh urls - nodejs/node#44992 - npm/cli#5761 https://nodejs.org/ko/blog/release/v16.19.0/ License-Update: Clarify vendored OpenSSL Toolkit is OpenSSL and SSLeay License-Update: JS Foundation -> OpenJS Foundation nodejs/node@e7ed56f Signed-off-by: Tim Orling <tim.orling@konsulko.com> Signed-off-by: Armin Kuster <akuster808@gmail.com> (cherry picked from commit 278ec08)
nmbath
pushed a commit
to victronenergy/meta-openembedded
that referenced
this pull request
Feb 24, 2023
* 16.18.0 (npm 8.19.2) introduced a regression in git+ssh urls - nodejs/node#44992 - npm/cli#5761 https://nodejs.org/ko/blog/release/v16.19.0/ License-Update: Clarify vendored OpenSSL Toolkit is OpenSSL and SSLeay License-Update: JS Foundation -> OpenJS Foundation nodejs/node@e7ed56f Signed-off-by: Tim Orling <tim.orling@konsulko.com> Signed-off-by: Armin Kuster <akuster808@gmail.com> (cherry picked from commit 278ec08)
sgunin
pushed a commit
to sgunin/oe-meta-openembedded-contrib
that referenced
this pull request
Mar 17, 2024
* 16.18.0 (npm 8.19.2) introduced a regression in git+ssh urls - nodejs/node#44992 - npm/cli#5761 https://nodejs.org/ko/blog/release/v16.19.0/ License-Update: Clarify vendored OpenSSL Toolkit is OpenSSL and SSLeay License-Update: JS Foundation -> OpenJS Foundation nodejs/node@e7ed56f Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was using
new URLwhich would fail on some urls thathosted-git-infois able to parse. But if we still get a url that can'tbe parsed, we now set it to be removed from the tree instead of
erroring.
Fixes: #5278