Skip to content

feat(core): remove deprecated --only-failed option #12471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrozenPandaz merged 1 commit into from
Oct 7, 2022
Merged

feat(core): remove deprecated --only-failed option #12471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions docs/generated/cli/affected-apps.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,6 @@ Default: false

Ignore cycles in the task graph

### ~~only-failed~~

Type: boolean

Default: false

**Deprecated:** The command to rerun failed projects will appear if projects fail. This now does nothing and will be removed in v15.

Isolate projects which previously failed

### plain

Produces a plain output for affected:apps and affected:libs
Expand Down
10 changes: 0 additions & 10 deletions docs/generated/cli/affected-graph.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,16 +139,6 @@ Default: false

Ignore cycles in the task graph

### ~~only-failed~~

Type: boolean

Default: false

**Deprecated:** The command to rerun failed projects will appear if projects fail. This now does nothing and will be removed in v15.

Isolate projects which previously failed

### open

Type: boolean
Expand Down
10 changes: 0 additions & 10 deletions docs/generated/cli/affected-libs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,6 @@ Default: false

Ignore cycles in the task graph

### ~~only-failed~~

Type: boolean

Default: false

**Deprecated:** The command to rerun failed projects will appear if projects fail. This now does nothing and will be removed in v15.

Isolate projects which previously failed

### plain

Produces a plain output for affected:apps and affected:libs
Expand Down
10 changes: 0 additions & 10 deletions docs/generated/cli/affected.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,16 +115,6 @@ Default: false

Ignore cycles in the task graph

### ~~only-failed~~

Type: boolean

Default: false

**Deprecated:** The command to rerun failed projects will appear if projects fail. This now does nothing and will be removed in v15.

Isolate projects which previously failed

### output-style

Type: string
Expand Down
10 changes: 0 additions & 10 deletions docs/generated/cli/format-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,6 @@ Default: false

Ignore cycles in the task graph

### ~~only-failed~~

Type: boolean

Default: false

**Deprecated:** The command to rerun failed projects will appear if projects fail. This now does nothing and will be removed in v15.

Isolate projects which previously failed

### projects

Type: array
Expand Down
10 changes: 0 additions & 10 deletions docs/generated/cli/format-write.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,6 @@ Default: false

Ignore cycles in the task graph

### ~~only-failed~~

Type: boolean

Default: false

**Deprecated:** The command to rerun failed projects will appear if projects fail. This now does nothing and will be removed in v15.

Isolate projects which previously failed

### projects

Type: array
Expand Down
10 changes: 0 additions & 10 deletions docs/generated/cli/print-affected.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,16 +109,6 @@ Default: false

Ignore cycles in the task graph

### ~~only-failed~~

Type: boolean

Default: false

**Deprecated:** The command to rerun failed projects will appear if projects fail. This now does nothing and will be removed in v15.

Isolate projects which previously failed

### runner

Type: string
Expand Down
10 changes: 0 additions & 10 deletions docs/generated/cli/run-many.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,16 +81,6 @@ Default: false

Ignore cycles in the task graph

### ~~only-failed~~

Type: boolean

Default: false

**Deprecated:** The command to rerun failed projects will appear if projects fail. This now does nothing and will be removed in v15.

Only run the target on projects which previously failed

### output-style

Type: string
Expand Down
16 changes: 8 additions & 8 deletions docs/generated/packages/nx.json
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 1 addition & 5 deletions docs/shared/angular-tutorial/11-test-affected-projects.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,7 @@ You will see the following:

Note that Nx only tried to retest `ui` and `todos`. It didn't retest `api` or `data` because there is no way that could be affected by the changes in this branch.

Run the command to retest the failed projects.

```sh
npx nx affected:test -- --only-failed
```
Simply, re-run the command to retest the failed projects. The already successful projects will be cached.

## Affected:

Expand Down
14 changes: 0 additions & 14 deletions packages/nx/src/command-line/nx-commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,13 +478,6 @@ function withAffectedOptions(yargs: yargs.Argv): yargs.Argv {
'This is the configuration to use when performing tasks on projects',
type: 'string',
})
.options('only-failed', {
deprecated:
'The command to rerun failed projects will appear if projects fail. This now does nothing and will be removed in v15.',
describe: 'Isolate projects which previously failed',
type: 'boolean',
default: false,
})
.option('verbose', {
type: 'boolean',
describe:
Expand Down Expand Up @@ -540,13 +533,6 @@ function withRunManyOptions(yargs: yargs.Argv): yargs.Argv {
'This is the configuration to use when performing tasks on projects',
type: 'string',
})
.options('only-failed', {
deprecated:
'The command to rerun failed projects will appear if projects fail. This now does nothing and will be removed in v15.',
describe: 'Only run the target on projects which previously failed',
type: 'boolean',
default: false,
})
.option('exclude', {
describe: 'Exclude certain projects from being processed',
type: 'array',
Expand Down
9 changes: 0 additions & 9 deletions packages/nx/src/utils/command-line-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ const runOne: string[] = [
'parallel',
'maxParallel',
'exclude',
'onlyFailed',
'help',
'skipNxCache',
'outputStyle',
Expand Down Expand Up @@ -116,7 +115,6 @@ export interface NxArgs {
head?: string;
exclude?: string[];
files?: string[];
onlyFailed?: boolean;
verbose?: boolean;
help?: boolean;
version?: boolean;
Expand Down Expand Up @@ -218,13 +216,6 @@ export function splitArgsIntoNxArgsAndOverrides(
nxArgs.configuration = 'production';
}

// TODO(v15): onlyFailed should not be an option
if (options.printWarnings && nxArgs.onlyFailed) {
output.warn({
title: `--onlyFailed is deprecated. All tasks will be run.`,
});
}

if (mode === 'affected') {
if (options.printWarnings && nxArgs.all) {
output.warn({
Expand Down