Skip to content

feat(react): deprecate styl from react and next for 17 #16135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaysoo merged 1 commit into from
Apr 12, 2023
Merged

feat(react): deprecate styl from react and next for 17 #16135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions docs/generated/packages/next/generators/application.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand All @@ -56,6 +52,11 @@
{
"value": "styled-jsx",
"label": "styled-jsx [ https://www.npmjs.com/package/styled-jsx ]"
},
{ "value": "none", "label": "None" },
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ] (DEPRECATED)"
}
]
}
Expand Down
10 changes: 5 additions & 5 deletions docs/generated/packages/next/generators/component.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand All @@ -58,7 +54,11 @@
"value": "styled-jsx",
"label": "styled-jsx [ https://www.npmjs.com/package/styled-jsx ]"
},
{ "value": "none", "label": "None" }
{ "value": "none", "label": "None" },
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ] (DEPRECATED)"
}
]
}
},
Expand Down
10 changes: 5 additions & 5 deletions docs/generated/packages/next/generators/library.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand All @@ -57,7 +53,11 @@
"value": "styled-jsx",
"label": "styled-jsx [ https://www.npmjs.com/package/styled-jsx ]"
},
{ "value": "none", "label": "None" }
{ "value": "none", "label": "None" },
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ] (DEPRECATED)"
}
]
}
},
Expand Down
10 changes: 5 additions & 5 deletions docs/generated/packages/next/generators/page.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand All @@ -64,7 +60,11 @@
"value": "styled-jsx",
"label": "styled-jsx [ https://www.npmjs.com/package/styled-jsx ]"
},
{ "value": "none", "label": "None" }
{ "value": "none", "label": "None" },
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ] (DEPRECATED)"
}
]
},
"x-priority": "important"
Expand Down
10 changes: 5 additions & 5 deletions docs/generated/packages/react/generators/application.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand All @@ -71,7 +67,11 @@
"value": "styled-jsx",
"label": "styled-jsx [ https://www.npmjs.com/package/styled-jsx ]"
},
{ "value": "none", "label": "None" }
{ "value": "none", "label": "None" },
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ] (DEPRECATED)"
}
]
}
},
Expand Down
10 changes: 5 additions & 5 deletions docs/generated/packages/react/generators/component.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand All @@ -68,7 +64,11 @@
"value": "styled-jsx",
"label": "styled-jsx [ https://www.npmjs.com/package/styled-jsx ]"
},
{ "value": "none", "label": "None" }
{ "value": "none", "label": "None" },
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ] (DEPRECATED)"
}
]
}
},
Expand Down
10 changes: 5 additions & 5 deletions docs/generated/packages/react/generators/host.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand All @@ -57,7 +53,11 @@
"value": "styled-jsx",
"label": "styled-jsx [ https://www.npmjs.com/package/styled-jsx ]"
},
{ "value": "none", "label": "None" }
{ "value": "none", "label": "None" },
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ] (DEPRECATED)"
}
]
}
},
Expand Down
10 changes: 5 additions & 5 deletions docs/generated/packages/react/generators/library.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand All @@ -67,7 +63,11 @@
"value": "styled-jsx",
"label": "styled-jsx [ https://www.npmjs.com/package/styled-jsx ]"
},
{ "value": "none", "label": "None" }
{ "value": "none", "label": "None" },
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ] (DEPRECATED)"
}
]
}
},
Expand Down
8 changes: 4 additions & 4 deletions docs/generated/packages/react/generators/remote.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand All @@ -57,6 +53,10 @@
"value": "styled-jsx",
"label": "styled-jsx [ https://www.npmjs.com/package/styled-jsx ]"
},
{
"value": "styl",
"label": "DEPRECATD: Stylus(.styl) [ http://stylus-lang.com ]"
},
{ "value": "none", "label": "None" }
]
}
Expand Down
4 changes: 0 additions & 4 deletions docs/generated/packages/web/generators/application.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl)[ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand Down
2 changes: 1 addition & 1 deletion docs/generated/packages/webpack/documents/webpack-plugins.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ module.exports = composePlugins(withNx(), (config) => {

## withWeb

The `withWeb` plugin adds support for CSS/SASS/Less/Stylus stylesheets, assets (such as images and fonts), and `index.html` processing.
The `withWeb` plugin adds support for CSS/SASS/Less stylesheets, assets (such as images and fonts), and `index.html` processing.

### Options

Expand Down
4 changes: 0 additions & 4 deletions docs/generated/packages/workspace/generators/preset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl)[ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand Down
2 changes: 1 addition & 1 deletion docs/shared/packages/webpack/webpack-plugins.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ module.exports = composePlugins(withNx(), (config) => {

## withWeb

The `withWeb` plugin adds support for CSS/SASS/Less/Stylus stylesheets, assets (such as images and fonts), and `index.html` processing.
The `withWeb` plugin adds support for CSS/SASS/Less stylesheets, assets (such as images and fonts), and `index.html` processing.

### Options

Expand Down
2 changes: 1 addition & 1 deletion nx-dev/nx-dev/lib/rspack/content/rspack-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module.exports = composePlugins(withNx(), (config) => {

## withWeb

The \`withWeb\` plugin adds support for CSS/SASS/Less/Stylus stylesheets, assets (such as images and fonts), and \`index.html\` processing.
The \`withWeb\` plugin adds support for CSS/SASS/Less stylesheets, assets (such as images and fonts), and \`index.html\` processing.

### Options

Expand Down
8 changes: 4 additions & 4 deletions nx-dev/nx-dev/lib/rspack/schema/generators/application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ export const schema = {
'SASS(.scss) [ http://sass-lang.com ]',
},
{
value: 'styl',
value: 'less',
label:
'Stylus(.styl) [ http://stylus-lang.com ]',
'LESS [ http://lesscss.org ]',
},
{
value: 'less',
value: 'styl',
label:
'LESS [ http://lesscss.org ]',
'DEPRECATED: Stylus(.styl) [ http://stylus-lang.com ]',
},
{
value: 'none',
Expand Down
7 changes: 0 additions & 7 deletions packages/create-nx-workspace/bin/create-nx-workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,13 +589,6 @@ async function determineStyle(
},
];

if (![Preset.AngularMonorepo, Preset.AngularStandalone].includes(preset)) {
choices.push({
name: 'styl',
message: 'Stylus(.styl) [ http://stylus-lang.com ]',
});
}

if (
[Preset.ReactMonorepo, Preset.ReactStandalone, Preset.NextJs].includes(
preset
Expand Down
12 changes: 8 additions & 4 deletions packages/next/src/generators/application/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand All @@ -56,6 +52,14 @@
{
"value": "styled-jsx",
"label": "styled-jsx [ https://www.npmjs.com/package/styled-jsx ]"
},
{
"value": "none",
"label": "None"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ] (DEPRECATED)"
}
]
}
Expand Down
8 changes: 4 additions & 4 deletions packages/next/src/generators/component/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand All @@ -63,6 +59,10 @@
{
"value": "none",
"label": "None"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ] (DEPRECATED)"
}
]
}
Expand Down
8 changes: 4 additions & 4 deletions packages/next/src/generators/library/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand All @@ -60,6 +56,10 @@
{
"value": "none",
"label": "None"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ] (DEPRECATED)"
}
]
}
Expand Down
8 changes: 4 additions & 4 deletions packages/next/src/generators/page/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ]"
},
{
"value": "less",
"label": "LESS [ http://lesscss.org ]"
Expand All @@ -69,6 +65,10 @@
{
"value": "none",
"label": "None"
},
{
"value": "styl",
"label": "Stylus(.styl) [ http://stylus-lang.com ] (DEPRECATED)"
}
]
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/generators/application/lib/install-common-dependencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function installCommonDependencies(
case 'less':
devDependencies = { less: lessVersion };
break;
case 'styl':
case 'styl': // @TODO(17): deprecated, going to be removed in Nx 17
devDependencies = { stylus: stylusVersion };
break;
}
Expand Down
Loading