fix(testing): deprecate cypress tsconfig option - #17165
Merged
barbados-clemens merged 1 commit intoJun 21, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
added
the
scope: testing tools
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 124e864. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
barbados-clemens
force-pushed
the
fix/cy-deprecate-tsconfig-opt
branch
from
May 24, 2023 16:11
bb53370 to
60cfcc2
Compare
barbados-clemens
force-pushed
the
fix/cy-deprecate-tsconfig-opt
branch
from
May 24, 2023 16:49
60cfcc2 to
ac3cee1
Compare
barbados-clemens
force-pushed
the
fix/cy-deprecate-tsconfig-opt
branch
from
May 24, 2023 18:57
ac3cee1 to
3ab314c
Compare
barbados-clemens
force-pushed
the
fix/cy-deprecate-tsconfig-opt
branch
from
May 31, 2023 19:32
3ab314c to
f526a67
Compare
barbados-clemens
force-pushed
the
fix/cy-deprecate-tsconfig-opt
branch
from
June 1, 2023 14:39
f526a67 to
3ddb93b
Compare
barbados-clemens
marked this pull request as ready for review
June 1, 2023 14:52
barbados-clemens
enabled auto-merge (squash)
June 1, 2023 19:34
barbados-clemens
force-pushed
the
fix/cy-deprecate-tsconfig-opt
branch
from
June 5, 2023 19:59
3ddb93b to
382782c
Compare
barbados-clemens
force-pushed
the
fix/cy-deprecate-tsconfig-opt
branch
from
June 12, 2023 13:45
382782c to
cec80bd
Compare
FrozenPandaz
requested changes
Jun 14, 2023
barbados-clemens
force-pushed
the
fix/cy-deprecate-tsconfig-opt
branch
from
June 16, 2023 17:09
cec80bd to
fbfd4e3
Compare
barbados-clemens
force-pushed
the
fix/cy-deprecate-tsconfig-opt
branch
from
June 21, 2023 14:34
fbfd4e3 to
124e864
Compare
FrozenPandaz
approved these changes
Jun 21, 2023
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
the tsconfig option for the cypress executor does not influence cypress ts compilation and so should be removed
Expected Behavior
no tsconfig option
Related Issue(s)
TODO:
Fixes #16963