fix(core): handle concurrent db connections better #28544
Conversation
Cammisuli
requested review from
a team,
FrozenPandaz and
vsavkin
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bc43ecf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
|
Failed to publish a PR release of this pull request, triggered by @Cammisuli. |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-28544-c9de3c0 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28544-c9de3c0
To request a new release for this pull request, mention someone from the Nx team or the |
- add retry mechanism for database operations - Add file locking to ensure safe creation of the database
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-28544-c61e456 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28544-c61e456
To request a new release for this pull request, mention someone from the Nx team or the |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-28544-73b1b41 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28544-73b1b41
To request a new release for this pull request, mention someone from the Nx team or the |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-28544-cbd2dad my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28544-cbd2dad
To request a new release for this pull request, mention someone from the Nx team or the |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-28544-9f394f8 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28544-9f394f8
To request a new release for this pull request, mention someone from the Nx team or the |
- Add `LockFile` struct for better lock file management - Introduce `initialize_db` function for clearer DB initialization - Move metadata table creation to a separate function - Enhance error handling in connection and lock file operations
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-28544-bc73507 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28544-bc73507
To request a new release for this pull request, mention someone from the Nx team or the |
- Update `query_row` to return `Result<Option<T>>` and improve error handling - Ensure optional extension is used in `rusqlite` imports - Adjust check for empty database version to handle `Ok(None)` - Fix cache query and logging - Correct tracing format and cache record existence check in cache module
- Add process tracing with `trace_span` - Replace `debug` logs with more relevant `trace` logs - Simplify `initialize_db` function by removing redundant `lock_file` parameter - Ensure metadata table creation only if it does not exist - Improve log messages for better traceability
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-28544-8a4b7d1 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28544-8a4b7d1
To request a new release for this pull request, mention someone from the Nx team or the |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-28544-bc43ecf my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-28544-bc43ecf
To request a new release for this pull request, mention someone from the Nx team or the |
(cherry picked from commit d3df76f)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
2 participants
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #