Skip to content

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Dec 20, 2024

Current Behavior

During the update to support Angular 19, the host and remote generators' updateSsrSetup function was missed.

This led to the creation of a second server.ts file, which would result in the node server trying to instantiate twice.

Expected Behavior

Fix the path normalization dependent on angular major version to ensure only one server will be instantiated.

Related Issue(s)

Fixes #29442

@Coly010 Coly010 requested a review from a team as a code owner December 20, 2024 13:03
@Coly010 Coly010 requested a review from FrozenPandaz December 20, 2024 13:03
@Coly010 Coly010 self-assigned this Dec 20, 2024
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 1:05pm
Copy link
Contributor

nx-cloud bot commented Dec 20, 2024

View your CI Pipeline Execution ↗ for commit 6795433.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 26m 14s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=3c3d2... ✅ Succeeded 26s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 25s View ↗
nx documentation --no-dte ✅ Succeeded 44s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-20 13:35:52 UTC

@Coly010 Coly010 merged commit 2143ea5 into master Dec 20, 2024
6 checks passed
@Coly010 Coly010 deleted the angular/fix-mf-ssr-setup branch December 20, 2024 13:40
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants