fix(core): handle package manager workspaces configuration in move generator #30268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution �� for commit af4d617.
☁️ Nx Cloud last updated this comment at |
JamesHenry
reviewed
Mar 5, 2025
JamesHenry
reviewed
Mar 5, 2025
packages/workspace/src/utilities/typescript/ts-solution-setup.ts
Outdated
Show resolved
Hide resolved
leosvelperez
force-pushed
the
workspace/move-handle-package-manager-workspaces
branch
from
3c46e21 to
84276ff
Compare
Coly010
approved these changes
Mar 5, 2025
…tches extra projects
leosvelperez
force-pushed
the
workspace/move-handle-package-manager-workspaces
branch
from
84276ff to
af4d617
Compare
FrozenPandaz
approved these changes
Mar 6, 2025
JamesHenry
approved these changes
Mar 11, 2025
leosvelperez
deleted the
workspace/move-handle-package-manager-workspaces
branch
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 14, 2025
…nerator (#30268) ## Current Behavior Moving a project included in the package manager workspaces setup to a new destination that's not matched by that configuration results in the project not included in the package manager workspaces setup. ## Expected Behavior Moving a project included in the package manager workspaces setup to a new destination that's not matched by that configuration should result in the new destination included in the workspaces setup. ## Related Issue(s) Fixes # (cherry picked from commit 432a645)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Moving a project included in the package manager workspaces setup to a new destination that's not matched by that configuration results in the project not included in the package manager workspaces setup.
Expected Behavior
Moving a project included in the package manager workspaces setup to a new destination that's not matched by that configuration should result in the new destination included in the workspaces setup.
Related Issue(s)
Fixes #