feat(core)!: drop support for node versions prior to 20.19.0 #30818

ndcunningham · 2025-04-22T19:20:23Z

BREAKING CHANGE: We are updating our minimum node version to 20.19.0 which drops support for all prior versions.

vercel · 2025-04-22T19:20:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	May 1, 2025 5:59am

nx-cloud · 2025-04-22T19:21:01Z

View your CI Pipeline Execution ↗ for commit 7cc58a7.

Command	Status	Duration	Result
`nx affected --targets=lint,test,build,e2e,e2e-ci`	✅ Succeeded	11m 31s	View ↗
`nx run-many -t check-imports check-commit check...`	✅ Succeeded	16s	View ↗
`nx-cloud record -- nx-cloud conformance:check`	✅ Succeeded	2s	View ↗
`nx-cloud record -- nx format:check`	✅ Succeeded	1s	View ↗
`nx-cloud record -- nx sync:check`	✅ Succeeded	<1s	View ↗
`nx documentation`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2025-05-01 06:13:24 UTC

JamesHenry

See slack thread

github-actions · 2025-04-22T20:56:13Z

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-30818-a84176c my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-30818-a84176c

Release details	📑
Published version	0.0.0-pr-30818-a84176c
Triggered by	@ndcunningham
Branch	feat/upgrade-to-node-20
Commit	a84176c
Workflow run	14604007199

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

github-actions · 2025-04-22T22:00:06Z

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-30818-b861e7d my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-30818-b861e7d

Release details	📑
Published version	0.0.0-pr-30818-b861e7d
Triggered by	@ndcunningham
Branch	feat/upgrade-to-node-20
Commit	b861e7d
Workflow run	14605127935

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

docs/generated/packages/workspace/documents/nx-nodejs-typescript-version-matrix.md

docs/shared/packages/workspace/nx-compatibility-matrix.md

.github/workflows/generate-embeddings.yml

packages/nx/native-packages/linux-arm64-gnu/package.json

beaussan · 2025-04-23T17:59:46Z

Hey there 👋

I suspect the node 20.19 was picked for the require(esm) support

If that's the case, you may want to support only node 22.12 and up instead of 22.x

Since it's not enabled under 22.12 by default, you would have node version in your support range that don't support require(esm)

See release notes for 22.12 https://nodejs.org/en/blog/release/v22.12.0

Remove engines entry for napi-rs BREAKING CHANGE: Node versions earlier to 20.19.0 docs(nx-dev): Fix node support matrix (cherry picked from commit 742b371)

github-actions · 2025-05-07T00:11:46Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

ndcunningham self-assigned this Apr 22, 2025

ndcunningham requested a review from a team as a code owner April 22, 2025 19:20

ndcunningham requested a review from AgentEnder April 22, 2025 19:20

JamesHenry requested changes Apr 22, 2025

View reviewed changes

ndcunningham force-pushed the feat/upgrade-to-node-20 branch from 5a0dd8e to a84176c Compare April 22, 2025 20:15

ndcunningham requested review from a team as code owners April 22, 2025 20:15

ndcunningham requested a review from isaacplmann April 22, 2025 20:15

ndcunningham changed the title ~~feat(core): Update base Node version to 20~~ Apr 22, 2025

ndcunningham requested a review from JamesHenry April 22, 2025 20:20

vercel bot deployed to Preview April 22, 2025 20:26 View deployment

ndcunningham force-pushed the feat/upgrade-to-node-20 branch from a84176c to b861e7d Compare April 22, 2025 20:45

vercel bot deployed to Preview April 22, 2025 20:55 View deployment

JamesHenry reviewed Apr 23, 2025

View reviewed changes

docs/generated/packages/workspace/documents/nx-nodejs-typescript-version-matrix.md Outdated Show resolved Hide resolved

JamesHenry reviewed Apr 23, 2025

View reviewed changes

docs/shared/packages/workspace/nx-compatibility-matrix.md Outdated Show resolved Hide resolved

jaysoo reviewed Apr 23, 2025

View reviewed changes

.github/workflows/generate-embeddings.yml Show resolved Hide resolved

vercel bot deployed to Preview April 23, 2025 15:17 View deployment

JamesHenry approved these changes Apr 23, 2025

View reviewed changes

jaysoo reviewed Apr 23, 2025

View reviewed changes

packages/nx/native-packages/linux-arm64-gnu/package.json Outdated Show resolved Hide resolved

ndcunningham force-pushed the feat/upgrade-to-node-20 branch from c18ae70 to 85646cb Compare April 23, 2025 17:19

vercel bot deployed to Preview April 23, 2025 17:28 View deployment

ndcunningham force-pushed the feat/upgrade-to-node-20 branch from 85646cb to 116a310 Compare April 23, 2025 17:47

vercel bot deployed to Preview April 23, 2025 17:57 View deployment

ndcunningham force-pushed the feat/upgrade-to-node-20 branch from 116a310 to 102abca Compare April 23, 2025 18:06

vercel bot deployed to Preview April 23, 2025 18:16 View deployment

vercel bot deployed to Preview April 28, 2025 20:21 View deployment

jaysoo approved these changes Apr 28, 2025

View reviewed changes

ndcunningham force-pushed the feat/upgrade-to-node-20 branch from 06688d3 to 7c50034 Compare April 29, 2025 23:15

vercel bot deployed to Preview April 29, 2025 23:26 View deployment

ndcunningham force-pushed the feat/upgrade-to-node-20 branch 2 times, most recently from 74544ca to 9a68bf8 Compare April 30, 2025 16:23

vercel bot deployed to Preview April 30, 2025 16:33 View deployment

ndcunningham force-pushed the feat/upgrade-to-node-20 branch from 9a68bf8 to b725bb6 Compare April 30, 2025 16:46

vercel bot deployed to Preview April 30, 2025 16:57 View deployment

ndcunningham added 5 commits April 30, 2025 22:13

feat(core)!: drop support for node versions prior to 20.19.0

5f535af

Remove engines entry for napi-rs BREAKING CHANGE: Node versions earlier to 20.19.0 docs(nx-dev): Fix node support matrix (cherry picked from commit 742b371)

fix(core): brew path for ci

1650234

fix(core): Update agents node version to 20.19.0

6fecd2b

feat(core): Update image for agents to ubuntu22.04-node20.19-v1

c61603f

fix(core): Update image to use absolute path

ca9f2e0

jaysoo force-pushed the feat/upgrade-to-node-20 branch from 19400e3 to ca9f2e0 Compare May 1, 2025 02:13

jaysoo added 3 commits April 30, 2025 22:33

chore(misc): undo changes to ci.yml

402f1f6

chore(misc): remove .nvmrc

e16ad15

chore(misc): add env vars for corepack

1db8b6d

jaysoo requested review from a team and Coly010 as code owners May 1, 2025 03:58

chore(misc): fix remix e2e

55787f2

jaysoo force-pushed the feat/upgrade-to-node-20 branch from 25c818c to 55787f2 Compare May 1, 2025 04:23

chore(misc): fix pnpm test for release lockfiles

d1b3901

jaysoo force-pushed the feat/upgrade-to-node-20 branch from 9904ce1 to d1b3901 Compare May 1, 2025 05:10

chore(misc): skip failing test in CI

7cc58a7

jaysoo force-pushed the feat/upgrade-to-node-20 branch from b56ca3f to 7cc58a7 Compare May 1, 2025 05:56

jaysoo merged commit 28ddb8e into master May 1, 2025
6 checks passed

jaysoo deleted the feat/upgrade-to-node-20 branch May 1, 2025 06:13

github-actions bot locked as resolved and limited conversation to collaborators May 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(core)!: drop support for node versions prior to 20.19.0 #30818

feat(core)!: drop support for node versions prior to 20.19.0 #30818

Uh oh!

ndcunningham commented Apr 22, 2025 •

edited

Loading

vercel bot commented Apr 22, 2025 •

edited

Loading

nx-cloud bot commented Apr 22, 2025 •

edited

Loading

JamesHenry left a comment

github-actions bot commented Apr 22, 2025

github-actions bot commented Apr 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beaussan commented Apr 23, 2025

Uh oh!

github-actions bot commented May 7, 2025

Labels

4 participants

feat(core)!: drop support for node versions prior to 20.19.0 #30818

feat(core)!: drop support for node versions prior to 20.19.0 #30818

Uh oh!

Conversation

ndcunningham commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

vercel bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

nx-cloud bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JamesHenry left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 22, 2025

🐳 We have a release for that!

github-actions bot commented Apr 22, 2025

🐳 We have a release for that!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beaussan commented Apr 23, 2025

Uh oh!

github-actions bot commented May 7, 2025

Labels

4 participants

ndcunningham commented Apr 22, 2025 •

edited

Loading

vercel bot commented Apr 22, 2025 •

edited

Loading

nx-cloud bot commented Apr 22, 2025 •

edited

Loading