Skip to content

feat(core): remove deprecated readWorkspaceConfig #30868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

feat(core): remove deprecated readWorkspaceConfig #30868

merged 1 commit into from
Apr 25, 2025

Conversation

leosvelperez
Copy link
Member

Remove the deprecated function readWorkspaceConfig from @nx/workspace.

BREAKING CHANGE: The previously deprecated readWorkspaceConfig function from @nx/workspace was removed.
@leosvelperez
feat(core): remove deprecated readWorkspaceConfig
1ba5c65 
Remove the deprecated function `readWorkspaceConfig`.

BREAKING CHANGE: The previously deprecated `readWorkspaceConfig` function was removed.
@leosvelperez leosvelperez self-assigned this Apr 25, 2025
@leosvelperez leosvelperez requested a review from a team as a code owner April 25, 2025 13:32
@leosvelperez leosvelperez requested a review from MaxKless April 25, 2025 13:32
@vercel Vercel
Copy link

vercel bot commented Apr 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 25, 2025 1:47pm
@nx-cloud Nx Cloud
Copy link
Contributor

nx-cloud bot commented Apr 25, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 1ba5c65.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-ci ✅ Succeeded 9m 50s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 21s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-25 15:28:33 UTC
FrozenPandaz
FrozenPandaz requested changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove getProjectsSync in this PR as well please?
@leosvelperez
Copy link
Member Author

Can you remove getProjectsSync in this PR as well please?

The PR already removes it. It's not mentioned in the breaking changes because, as far as I can see, it's not part of any public API.
FrozenPandaz
FrozenPandaz approved these changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@FrozenPandaz FrozenPandaz enabled auto-merge (squash) April 25, 2025 14:05
@FrozenPandaz FrozenPandaz merged commit 840aef8 into master Apr 25, 2025
6 checks passed
@FrozenPandaz FrozenPandaz deleted the core/remove-readWorkspaceConfig branch April 25, 2025 15:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants

@leosvelperez @FrozenPandaz