Skip to content

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented May 14, 2025

…n 75 characters of width

Current Behavior

Auto layout is always based on an aspect ratio which lead to horizontal layout even when there is very little horizontal space.

Expected Behavior

Auto layout prefers vertical layout with less than 75 characters of width which will allow 50 characters (75 * 2/3) for terminal output. It should be enough to show a URL in most cases:

image
image

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested review from a team as code owners May 14, 2025 21:32
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 17, 2025 1:43pm
Copy link
Contributor

nx-cloud bot commented May 14, 2025

View your CI Pipeline Execution ↗ for commit 594897b.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 32m 15s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 3s View ↗
nx documentation ✅ Succeeded 5m 15s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-17 14:23:43 UTC

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense, we can definitely refine the auto detection a lot further, the initial work just got the "plumbing" in place. Please add a snapshot test for this

@FrozenPandaz FrozenPandaz requested a review from JamesHenry May 16, 2025 18:55
@FrozenPandaz FrozenPandaz dismissed JamesHenry’s stale review May 16, 2025 18:56

Added the snapshots :)

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) May 16, 2025 18:56
@FrozenPandaz FrozenPandaz merged commit fa654c6 into master May 17, 2025
6 checks passed
@FrozenPandaz FrozenPandaz deleted the prefer-vertical branch May 17, 2025 14:24
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2025
@FrozenPandaz FrozenPandaz added scope: angular Issues related to Angular support in Nx priority: medium Medium Priority (not high, not low priority) labels Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

priority: medium Medium Priority (not high, not low priority) scope: angular Issues related to Angular support in Nx

4 participants