fix(module-federation): use runtimeChunk false when not in dev mode #31256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 32c669f.
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
May 21, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
May 21, 2025
…31256) ## Current Behavior In #30637 `runtimeChunk: false` was removed to allow HMR for styles. ## Expected Behavior We need to set runtimeChunk to false or multiple when working with MF. #31114 (comment) ## Related Issue(s) Fixes #31114 (cherry picked from commit 1ab77c8)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
In #30637
runtimeChunk: falsewas removed to allow HMR for styles.Expected Behavior
We need to set runtimeChunk to false or multiple when working with MF.
#31114 (comment)
Related Issue(s)
Fixes #31114