Skip to content

fix(core): handle killing child processes of continuous tasks on Windows #31296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

fix(core): handle killing child processes of continuous tasks on Windows #31296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions packages/nx/src/executors/run-commands/running-tasks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,21 +359,15 @@ class RunningNodeProcess implements RunningTask {

kill(signal?: NodeJS.Signals): Promise<void> {
return new Promise<void>((res, rej) => {
if (process.platform === 'win32') {
if (this.childProcess.kill(signal)) {
res();
treeKill(this.childProcess.pid, signal, (err) => {
// On Windows, tree-kill (which uses taskkill) may fail when the process or its child process is already terminated.
// Ignore the errors, otherwise we will log them unnecessarily.
if (err && process.platform !== 'win32') {
rej(err);
} else {
rej('Unable to kill process');
res();
}
} else {
treeKill(this.childProcess.pid, signal, (err) => {
if (err) {
rej(err);
} else {
res();
}
});
}
});
});
}

Expand Down
Loading