-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(core): add live durations for running tasks in the tui #31897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit c36490c
☁️ Nx Cloud last updated this comment at |
task_item.update_status(TaskStatus::InProgress); | ||
if task_item.start_time.is_none() { | ||
// It should be set, but just in case | ||
task_item.start_time = Some(current_time); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move defining current time into here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claude can you move defining current_time into here please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude finished @FrozenPandaz's task —— View job
Moving current_time definition ✅
I'll move the current_time
definition to the requested location as suggested by @FrozenPandaz.
Todo List:
- Read the current tasks_list.rs file to understand the code structure
- Identify where
current_time
is currently defined - Move it to the requested location (around line 727)
- Test the change by running appropriate commands
- Commit and push the changes
Changes Made:
- Moved
current_time
definition from line 721 to line 726 (right before where it's used) - This improves code organization by defining the variable closer to its usage
- The change is in the
start_tasks
method where it's only called whentask_item.start_time.is_none()
Build Status:
✅ The change compiles successfully with no errors (tested with cargo build --release
)
Commit Details:
- Commit: 6fe3d18
- Message: refactor(core): move current_time definition closer to usage in tasks_list.rs
- Status: ✅ Successfully pushed to origin/core/tui-live-durations
The current_time
variable is now defined right before its usage, improving code readability and organization as requested.
@claude please fix the commit message so that it conforms to standards. |
Claude finished @FrozenPandaz's task ���— View job Fixing Commit Message Standards ✅I've successfully fixed the commit message to conform to the repository standards. Todo List:
Analysis:Current commits:
Issue Found: The first commit used
Fix Applied:✅ Changed commit message from: To: The commit has been successfully amended and force-pushed to the |
6fe3d18
to
c36490c
Compare
## Current Behavior The TUI doesn't display live durations for running tasks. <img width="506" height="384" alt="image" src="https://github.com/user-attachments/assets/0c9d2ad6-810c-4785-9e0e-a9e56c86ba7f" /> ## Expected Behavior The TUI should display live durations for running tasks. <img width="499" height="378" alt="image" src="https://github.com/user-attachments/assets/2a675c42-3268-4faf-83d7-f747ad52ce35" /> --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The TUI doesn't display live durations for running tasks.
Expected Behavior
The TUI should display live durations for running tasks.