Skip to content

Conversation

leosvelperez
Copy link
Member

Current Behavior

The TUI doesn't display live durations for running tasks.

image

Expected Behavior

The TUI should display live durations for running tasks.

image
@leosvelperez leosvelperez self-assigned this Jul 11, 2025
@leosvelperez leosvelperez requested review from a team as code owners July 11, 2025 16:18
@leosvelperez leosvelperez requested a review from AgentEnder July 11, 2025 16:18
Copy link

vercel bot commented Jul 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 14, 2025 5:45pm
Copy link
Contributor

nx-cloud bot commented Jul 11, 2025

View your CI Pipeline Execution ↗ for commit c36490c

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 43m 33s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx documentation ✅ Succeeded 1m 34s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-14 18:15:43 UTC

task_item.update_status(TaskStatus::InProgress);
if task_item.start_time.is_none() {
// It should be set, but just in case
task_item.start_time = Some(current_time);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move defining current time into here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claude can you move defining current_time into here please?

Copy link
Contributor

@claude claude bot Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude finished @FrozenPandaz's task —— View job


Moving current_time definition ✅

I'll move the current_time definition to the requested location as suggested by @FrozenPandaz.

Todo List:

  • Read the current tasks_list.rs file to understand the code structure
  • Identify where current_time is currently defined
  • Move it to the requested location (around line 727)
  • Test the change by running appropriate commands
  • Commit and push the changes

Changes Made:

  • Moved current_time definition from line 721 to line 726 (right before where it's used)
  • This improves code organization by defining the variable closer to its usage
  • The change is in the start_tasks method where it's only called when task_item.start_time.is_none()

Build Status:

✅ The change compiles successfully with no errors (tested with cargo build --release)

Commit Details:

  • Commit: 6fe3d18
  • Message: refactor(core): move current_time definition closer to usage in tasks_list.rs
  • Status: ✅ Successfully pushed to origin/core/tui-live-durations

The current_time variable is now defined right before its usage, improving code readability and organization as requested.


@FrozenPandaz
Copy link
Collaborator

@claude please fix the commit message so that it conforms to standards.

Copy link
Contributor

claude bot commented Jul 14, 2025

Claude finished @FrozenPandaz's task ���— View job


Fixing Commit Message Standards ✅

I've successfully fixed the commit message to conform to the repository standards.

Todo List:

  • Check current commit messages in the branch
  • Review commitizen.js for valid scopes and format requirements
  • Identify any non-conforming commit messages
  • Fix commit messages using git rebase/amend
  • Push corrected commits to the branch

Analysis:

Current commits:

  • 6fe3d18b refactor(core): move current_time definition closer to usage in tasks_list.rs
  • 303a93f7 feat(core): add live durations for running tasks in the tui

Issue Found: The first commit used refactor as the type, but the valid types in scripts/commitizen.js are:

  • feat, fix, docs, cleanup, chore

Fix Applied:

✅ Changed commit message from:
refactor(core): move current_time definition closer to usage in tasks_list.rs

To:
cleanup(core): move current_time definition closer to usage in tasks_list.rs

The commit has been successfully amended and force-pushed to the core/tui-live-durations branch. The commit message now conforms to the repository's conventional commit standards.


@FrozenPandaz FrozenPandaz merged commit 2527519 into master Jul 15, 2025
7 checks passed
@FrozenPandaz FrozenPandaz deleted the core/tui-live-durations branch July 15, 2025 13:57
ndcunningham pushed a commit that referenced this pull request Jul 15, 2025
## Current Behavior

The TUI doesn't display live durations for running tasks.

<img width="506" height="384" alt="image"
src="https://github.com/user-attachments/assets/0c9d2ad6-810c-4785-9e0e-a9e56c86ba7f"
/>

## Expected Behavior

The TUI should display live durations for running tasks.

<img width="499" height="378" alt="image"
src="https://github.com/user-attachments/assets/2a675c42-3268-4faf-83d7-f747ad52ce35"
/>

---------

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants