Skip to content

fix(js): handle npm 11 warnings in stderr during registry version resolution #32223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

fix(js): handle npm 11 warnings in stderr during registry version resolution #32223

merged 1 commit into from
Aug 5, 2025

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Aug 5, 2025 •
edited
Loading

Current Behaviour

E2e tests fail with Node 24 because npm 11 writes deprecation warnings to stderr even on successful commands, causing registry version resolution to fail.

Expected Behaviour

Registry version resolution should work with npm 11 warnings in stderr.

References

 NX   Unable to resolve the current version from the registry: "registry=http://localhost:4873" tag=latest. Please ensure that the package exists in the registry in order to use the "registry" currentVersionResolver. Alternatively, you can use the --first-release option or set "release.version.fallbackCurrentVersionResolver" to "disk" in order to fallback to the version on disk when the registry lookup fails.

https://staging.nx.app/runs/l9kRV3E6ST
@ndcunningham
fix(js): handle npm 11 warnings in stderr during registry version res…
552a885 
…olution

npm 11+ (bundled with Node 24.3) writes deprecation warnings about unknown
environment configurations to stderr even when commands succeed. The registry
version resolver was incorrectly rejecting any npm view command with stderr
content, causing e2e tests to fail with Node 24.3.

This change updates the error handling to only reject on actual errors,
ignoring npm warning messages that start with 'npm warn'.
@ndcunningham ndcunningham requested a review from a team as a code owner August 5, 2025 03:26
@vercel Vercel
Copy link

vercel bot commented Aug 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Aug 5, 2025 3:36am
@nx-cloud Nx Cloud
Copy link
Contributor

nx-cloud bot commented Aug 5, 2025 •
edited
Loading

View your CI Pipeline Execution �� for commit 552a885

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 57m 40s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 59s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 3s View ↗
nx documentation ✅ Succeeded 1m 21s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-05 04:30:37 UTC
@ndcunningham ndcunningham self-assigned this Aug 5, 2025
@ndcunningham ndcunningham mentioned this pull request Aug 5, 2025
Merged
@jaysoo jaysoo merged commit 98ee167 into master Aug 5, 2025
7 checks passed
@jaysoo jaysoo deleted the fix/node-24-npm-11-compatibility branch August 5, 2025 13:19
This was referenced Aug 6, 2025
Closed
Closed
@github-actions GitHub Actions
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

scope: js

3 participants

@ndcunningham @Coly010 @jaysoo