fix(core): include nested library dependencies in generated package.json #32313
+159
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using build targets with nested library dependencies (App -> lib1 -> lib2),
dependencies from the deepest libraries were not being included in the generated
package.json due to restrictive target input patterns.
This fix adds an isTransitiveDependency parameter to findAllNpmDeps function that
uses broader file patterns ({projectRoot}/**/*) when processing transitive
project dependencies instead of the restrictive build target patterns.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 10cb939
☁️ Nx Cloud last updated this comment at |
Coly010
changed the title
AgentEnder
approved these changes
Aug 12, 2025
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using build targets with nested library dependencies (App -> lib1 -> lib2),
dependencies from the deepest libraries were not being included in the generated
package.json due to restrictive target input patterns.
This fix adds an isTransitiveDependency parameter to findAllNpmDeps function that
uses broader file patterns ({projectRoot}/**/*) when processing transitive
project dependencies instead of the restrictive build target patterns.
Fixes #30895