fix(angular): set the tsConfig option when possible to aid with angular migrations
#32355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leosvelperez
requested review from
a team,
AgentEnder,
FrozenPandaz and
jaysoo
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit 77fa251
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Aug 14, 2025
leosvelperez
force-pushed
the
fix/issue-32138
branch
from
b1ab595 to
e5d4d38
Compare
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
leosvelperez
force-pushed
the
fix/issue-32138
branch
from
e5d4d38 to
77fa251
Compare
barbados-clemens
approved these changes
Aug 19, 2025
jaysoo
approved these changes
Aug 19, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 22, 2025
…ular migrations (#32355) ## Current Behavior Running Angular migrations (particularly Angular Material migrations) normally results in many warnings stating that projects were skipped. This happens because Angular migrations make some assumptions that are not guaranteed in Nx monorepos: - build and test tasks are literally called `build` and `test` (it they have a different name, the Angular migrations don't handle them) - those tasks must have a `tsConfig` option set in the task `options` object While Nx can't change the first assumption, it can ensure that `tsConfig` is set in some tasks that allow it. ## Expected Behavior Tasks using the `@nx/angular:package`, `@nx/angular:ng-packagr-lite`, and `@nx/jest:jest` executors should have the `tsConfig` option set to aid the Angular migrations to run. Note: This PR restores the `tsConfig` option for the `@nx/jest:jest` executor that was recently removed. The option description states that it is only metadata for Angular migrations and is not used by the executor. The option will only be set by Nx generators for Angular projects. ## Related Issue(s) Fixes #32138 (cherry picked from commit 74e0de0)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Running Angular migrations (particularly Angular Material migrations) normally results in many warnings stating that projects were skipped. This happens because Angular migrations make some assumptions that are not guaranteed in Nx monorepos:
buildandtest(it they have a different name, the Angular migrations don't handle them)tsConfigoption set in the taskoptionsobjectWhile Nx can't change the first assumption, it can ensure that
tsConfigis set in some tasks that allow it.Expected Behavior
Tasks using the
@nx/angular:package,@nx/angular:ng-packagr-lite, and@nx/jest:jestexecutors should have thetsConfigoption set to aid the Angular migrations to run.Note: This PR restores the
tsConfigoption for the@nx/jest:jestexecutor that was recently removed. The option description states that it is only metadata for Angular migrations and is not used by the executor. The option will only be set by Nx generators for Angular projects.Related Issue(s)
Fixes #32138